Bug #46187 for DBIx-Class-EncodedColumn: FAIL test on MSWin32

Mon May 18 14:59:31 2009 stro [...] cpan.org - Ticket created

Subject:

FAIL test on MSWin32

Hi Guillermo, Test t/02digest.t fails under Windows, because t/lib/DigestTest.pm tries to unlink a file which is still open, and it is impossible under MSWin32 environment. Can you add $schema->storage()->disconnect(); before calling DigestTest->clear; , so your dist will pass tests correctly? -- Serguei Trouchelle

Mon Jul 27 04:28:53 2009 kmx [...] cpan.org - Correspondence added

Hi, I have prepared a patched version solving this issue via patch described in previous post. It is 100% ready for PAUSE upload as DBIx-Class-EncodedColumn-0.00003.tar.gz The exact changes made can be inspected in enclosed *.diff Please consider releasing this version - it would be nice to be able to install this module without failing test on Win32. Thanks. -- kmx

Download DBIx-Class-EncodedColumn-0.00003.tar.gz
application/x-gzip 23.1k

Message body not shown because it is not plain text.

diff -r -u DBIx-Class-EncodedColumn-0.00002/Changes DBIx-Class-EncodedColumn-0.00003/Changes --- DBIx-Class-EncodedColumn-0.00002/Changes 2008-07-29 00:16:02.000000000 +0200 +++ DBIx-Class-EncodedColumn-0.00003/Changes 2009-07-27 10:13:26.000000000 +0200 @@ -1,3 +1,6 @@ +0.00003 2009-07-27 + - Win32 compatibility patch for 02digest.t + 0.00002 2008-07-27 - Support for Crypt::OpenPGP diff -r -u DBIx-Class-EncodedColumn-0.00002/lib/DBIx/Class/EncodedColumn.pm DBIx-Class-EncodedColumn-0.00003/lib/DBIx/Class/EncodedColumn.pm --- DBIx-Class-EncodedColumn-0.00002/lib/DBIx/Class/EncodedColumn.pm 2008-07-29 00:40:02.000000000 +0200 +++ DBIx-Class-EncodedColumn-0.00003/lib/DBIx/Class/EncodedColumn.pm 2009-07-27 10:13:26.000000000 +0200 @@ -9,7 +9,7 @@ __PACKAGE__->mk_classdata( _column_encoders => {} ); -our $VERSION = '0.00002'; +our $VERSION = '0.00003'; sub register_column { my $self = shift; diff -r -u DBIx-Class-EncodedColumn-0.00002/META.yml DBIx-Class-EncodedColumn-0.00003/META.yml --- DBIx-Class-EncodedColumn-0.00002/META.yml 2008-07-29 00:42:44.000000000 +0200 +++ DBIx-Class-EncodedColumn-0.00003/META.yml 2009-07-27 10:13:26.000000000 +0200 @@ -24,4 +24,4 @@ Sub::Name: 0.04 resources: license: http://dev.perl.org/licenses/ -version: 0.00002 +version: 0.00003 diff -r -u DBIx-Class-EncodedColumn-0.00002/t/02digest.t DBIx-Class-EncodedColumn-0.00003/t/02digest.t --- DBIx-Class-EncodedColumn-0.00002/t/02digest.t 2008-07-29 00:29:12.000000000 +0200 +++ DBIx-Class-EncodedColumn-0.00003/t/02digest.t 2009-07-27 10:13:26.000000000 +0200 @@ -178,6 +178,7 @@ } +$schema->storage()->disconnect(); DigestTest->clear; #TODO

Mon Jul 27 04:28:54 2009 The RT System itself - Status changed from 'new' to 'open'

Fri Aug 14 09:30:07 2009 kmx [...] cpan.org - Correspondence added

Hi, can I somehow help with getting the fix for issue discussed in this RT into official release? My proposal is described in the previous post. -- kmx

Fri Aug 28 02:46:14 2009 kmx [...] cpan.org - Correspondence added

I do not want to push on you but if you give me: 1) co-maint 2) commit priv to http://dev.catalystframework.org/svnweb/bast/log/trunk/DBIx-Class-EncodedColumn/ I can fix this as well as the other currently open RT. At both places (pause, devcatalyst) I am "KMX". -- kmx

Wed Apr 28 21:32:58 2010 frioux [...] gmail.com - Correspondence added

This currently builds on Trouchelle and on Strawberry. I'm closing it. Please reopen if it's still actually an issue.

Wed Apr 28 21:32:59 2010 frioux [...] gmail.com - Status changed from 'open' to 'resolved'