Bug #46095 for Scalar-List-Utils: Failed build - make/compile fails on Win32 for v1.20 (read-only file issue)

Thu May 14 21:46:07 2009 RIVY [...] cpan.org - Ticket created

Subject:

Failed build - make/compile fails on Win32 for v1.20 (read-only file issue)

Scalar-List-Utils-v1.20 fails to build under various Win32 machines at the line: C:\perl\bin\perl.exe "-Iblib\arch" "-Iblib\lib" xs_version.PL xs_version If XS.pm is changed to read-write from read-only ("attrib -r blib\lib\List\Util\XS.pm"), the make/compile will succeed although testing still fails on my Win32/perlv5.8.8 machine during t/stack-corruption.t at "# Failed test at t/stack-corruption.t line 25." (A CPAN Testers report has been submitted.) Thanks for all the hard work on this module. It's quite useful. - Roy Ivy

Thu May 14 21:59:40 2009 gbarr [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #46095] Failed build - make/compile fails on Win32 for v1.20 (read-only file issue)
Date:	Thu, 14 May 2009 20:59:02 -0500
To:	bug-Scalar-List-Utils [...] rt.cpan.org
From:	Graham Barr <gbarr [...] pobox.com>

On May 14, 2009, at 8:46 PM, Roy Ivy III via RT wrote: Show quoted text

> C:\perl\bin\perl.exe "-Iblib\arch" "-Iblib\lib" xs_version.PL > xs_version > > If XS.pm is changed to read-write from read-only ("attrib -r > blib\lib\List\Util\XS.pm"), the make/compile will succeed although

xs_version.PL does an unlink on the file first. I assume that failed then I am not familiar with win32, why would unlink on the file fail ? Show quoted text

> testing still fails on my Win32/perlv5.8.8 machine during > t/stack-corruption.t at "# Failed test at t/stack-corruption.t line > 25." (A CPAN Testers report has been submitted.)

I have not seen any reports yet. 5.8.8 is not supposed to have that issue. The test was added because 5.8.9 and 5.10.0 did have the issue but it has been fixed in the core for future versions Graham.

Thu May 14 21:59:41 2009 The RT System itself - Status changed from 'new' to 'open'

Fri May 15 01:38:10 2009 GBARR [...] CPAN.ORG - Correspondence added

Can you try http://github.com/gbarr/Scalar-List-Utils/tree/next the download link will create a tar or zip file I changed the build system to not require to modify the file in blib

Fri May 15 12:05:42 2009 roy.ivy.iii [...] nmail.com - Correspondence added

Subject:	RE: [rt.cpan.org #46095] Failed build - make/compile fails on Win32 for v1.20 (read-only file issue)
Date:	Fri, 15 May 2009 12:02:03 -0400
To:	<bug-Scalar-List-Utils [...] rt.cpan.org>, <RIVY [...] cpan.org>
From:	"Roy Ivy III" <roy.ivy.iii [...] nmail.com>

Show quoted text

>From: Graham Barr via RT [mailto:bug-Scalar-List-Utils@rt.cpan.org] >Sent: Thursday, May 14, 2009 9:00 PM >To: RIVY@cpan.org >Subject: Re: [rt.cpan.org #46095] Failed build - make/compile fails on Win32 for v1.20 (read-only file issue) > ><URL: http://rt.cpan.org/Ticket/Display.html?id=46095 > > >On May 14, 2009, at 8:46 PM, Roy Ivy III via RT wrote:

>> C:\perl\bin\perl.exe "-Iblib\arch" "-Iblib\lib" xs_version.PL >> xs_version >> >> If XS.pm is changed to read-write from read-only ("attrib -r >> blib\lib\List\Util\XS.pm"), the make/compile will succeed although

> >xs_version.PL does an unlink on the file first. I assume that failed >then > >I am not familiar with win32, why would unlink on the file fail ?

I'm not sure why it's failing; I don't remember running into this problem recently. A quick permissions check shows ownership and read-write of the directory containing XS.pm. When the build fails at ` C:\Perl\bin\perl.exe "-Iblib\arch" "-Iblib\lib" xs_version.PL xs_version`, unlinking the file manually with `perl -e "unlink qq{blib/lib/List/Util/XS.pm}"` works correctly/removes the file. And a re-make/compile after issuing an `attrib -r blib\lib\List\Util\XS.pm` (removing the READONLY attribute) completes without error. Show quoted text

>> testing still fails on my Win32/perlv5.8.8 machine during >> t/stack-corruption.t at "# Failed test at t/stack-corruption.t line >> 25." (A CPAN Testers report has been submitted.)

> >I have not seen any reports yet. 5.8.8 is not supposed to have >that issue. The test was added because 5.8.9 and 5.10.0 did have >the issue but it has been fixed in the core for future versions

Yes, my v5.6.1 test VM skips the test with a message to that effect. But, my main machine, with version v5.8.8, definitely fails at that one test file. I haven't tried my v5.10.0 test machine as of yet. - Roy

Fri May 15 12:05:44 2009 roy.ivy.iii [...] nmail.com - Correspondence added

Subject:	RE: [rt.cpan.org #46095] Failed build - make/compile fails on Win32 for v1.20 (read-only file issue)
Date:	Fri, 15 May 2009 12:04:40 -0400
To:	<bug-Scalar-List-Utils [...] rt.cpan.org>, <RIVY [...] cpan.org>
From:	"Roy Ivy III" <roy.ivy.iii [...] nmail.com>

Show quoted text

>From: Graham_Barr via RT [mailto:bug-Scalar-List-Utils@rt.cpan.org] >Sent: Friday, May 15, 2009 12:38 AM >To: RIVY@cpan.org >Subject: [rt.cpan.org #46095] Failed build - make/compile fails on Win32 for v1.20 (read-only file issue) > ><URL: https://rt.cpan.org/Ticket/Display.html?id=46095 > > >Can you try > >http://github.com/gbarr/Scalar-List-Utils/tree/next > >the download link will create a tar or zip file > >I changed the build system to not require to modify the file in blib

It makes/compiles on perl v5.8.8 machine without error (still fails `nmake test` at the t/stack-corruption.t test). Successful make/test/install on v5.6.1 machine. - Roy

Fri May 15 19:25:37 2009 RIVY [...] cpan.org - Correspondence added

On Thu May 14 21:59:40 2009, gbarr@pobox.com wrote: Show quoted text

> On May 14, 2009, at 8:46 PM, Roy Ivy III via RT wrote:

> > C:\perl\bin\perl.exe "-Iblib\arch" "-Iblib\lib" xs_version.PL > > xs_version > > > > If XS.pm is changed to read-write from read-only ("attrib -r > > blib\lib\List\Util\XS.pm"), the make/compile will succeed although

> > xs_version.PL does an unlink on the file first. I assume that failed > then > > I am not familiar with win32, why would unlink on the file fail ?

This patch (adding a `chmod 0600`) also corrects the problem.

--- xs_version.PL.ORIG Wed Sep 10 18:59:57 2008 +++ xs_version.PL Fri May 15 18:20:04 2009 @@ -18,6 +18,7 @@ $line =~ s/^\$VERSION/# VERSION/; } } +chmod 0600, $xs_pm; unlink($xs_pm); open(FH,">$xs_pm") or die "Cannot open $xs_pm: $!\n"; print FH @file;

Mon May 18 21:08:14 2009 GBARR [...] CPAN.ORG - Status changed from 'open' to 'resolved'

Mon May 18 21:08:15 2009 GBARR [...] CPAN.ORG - Fixed in 1.21 added