| Subject: | Passing tests have misleading description |
When running tests in verbose mode the module produces output like:
$ prove -lrv t/01.no.tabs.t
t/01.no.tabs.t ..
ok 1 - Found tabs in 'lib/Catalyst/Plugin/ErrorCatcher.pm'
ok 2 - Found tabs in 'lib/Catalyst/Plugin/ErrorCatcher/Email.pm'
ok 3 - Found tabs in 't/lib/TestApp.pm'
ok 4 - Found tabs in 't/lib/TestApp/Exception.pm'
ok 5 - Found tabs in 't/lib/TestApp/Controller/Foo.pm'
1..5
ok
All tests successful.
This is slightly confusing, and definitely misleading.
I've attached a patch that sets a more meaningful message when using
all_perl_files_ok(), which doesn't accept an argument for $test_text
| Subject: | test-notabs-0.8.patch |
diff -Naur lib.orig/Test/NoTabs.pm lib/Test/NoTabs.pm
--- lib.orig/Test/NoTabs.pm 2009-05-14 22:04:45.000000000 +0100
+++ lib/Test/NoTabs.pm 2009-05-14 22:05:26.000000000 +0100
@@ -86,7 +86,7 @@
my @files = _all_perl_files( @_ );
_make_plan();
foreach my $file ( @files ) {
- notabs_ok($file);
+ notabs_ok($file, "no tabs in $file");
}
}