Skip Menu |

This queue is for tickets about the Math-Random-ISAAC-XS CPAN distribution.

Report information
The Basics
Id: 46071
Status: resolved
Priority: 0/
Queue: Math-Random-ISAAC-XS

People
Owner: Nobody in particular
Requestors: taro.nishino [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.0.5
Fixed in: (no value)



Subject: UINT32_MAX is part of C99
Dear Jonathan, UINT32_MAX is part of C99, so that the compilation fails under the compilers that don't support C99. May I ask you a favour? Could you apply the following patch? --- ISAAC.xs.orig Wed May 13 03:18:13 2009 +++ ISAAC.xs Thu May 14 20:38:33 2009 @@ -15,6 +15,10 @@ #include "rand.h" #include "standard.h" +#ifndef UINT32_MAX + #define UINT32_MAX (4294967295U) +#endif + typedef randctx * Math__Random__ISAAC__XS; MODULE = Math::Random::ISAAC::XS PACKAGE = Math::Random::ISAAC::XS Best regards, Taro Nishino
Hello there: Thank you for the bug report. I have applied your patch in standard.h instead of the XS file, as I believe it belongs there. I have not seen any failing test reports due to this (yet), so I did not think it to be a problem. I've corrected the SVN version but I'm not going to upload a new version until more major changes happen, or unless you have a need to get this new version on CPAN earlier. Please let me know if the latter is the case. Hope this resolves your problem. I'm setting the bug to resolved, but please feel free to re-open it if there is anything else, or if you wish a new package to be pushed to CPAN ASAP. Cheers, Jonathan On Thu May 14 08:13:44 2009, taro-nishino wrote: Show quoted text
> Dear Jonathan, > > UINT32_MAX is part of C99, so that the compilation fails under the > compilers that don't > support C99. > May I ask you a favour? Could you apply the following patch? > > --- ISAAC.xs.orig Wed May 13 03:18:13 2009 > +++ ISAAC.xs Thu May 14 20:38:33 2009 > @@ -15,6 +15,10 @@ > #include "rand.h" > #include "standard.h" > > +#ifndef UINT32_MAX > + #define UINT32_MAX (4294967295U) > +#endif > + > typedef randctx * Math__Random__ISAAC__XS; > > MODULE = Math::Random::ISAAC::XS PACKAGE = Math::Random::ISAAC::XS > > > Best regards, > Taro Nishino