Skip Menu |

This queue is for tickets about the CPANPLUS CPAN distribution.

Report information
The Basics
Id: 46055
Status: resolved
Priority: 0/
Queue: CPANPLUS

People
Owner: Nobody in particular
Requestors: kbrint [...] rufus.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: CPANPLUS::Dist::MM::prepare fails when directory has spaces
When CPANPLUS is being installed from a path with spaces, it fails in t/04_CPANPLUS-Module.t. Calling IPC::Cmd::run with a scalar command results in splitting on spaces, which produces the bad results. Instead, since we already have all 4 arguments individually, we should pass an array reference to IPC::Cmd::run(). The attached patch fixes the problem. Please integrate it into a future version of CPANPLUS. Thanks!
Subject: patch2
I think the patch attachment may not have worked... ? Attaching again.
Download patch2
application/octet-stream 480b

Message body not shown because it is not plain text.

On Wed May 13 18:36:32 2009, KBRINT wrote: Show quoted text
> When CPANPLUS is being installed from a path with spaces, it fails in > t/04_CPANPLUS-Module.t. > Calling IPC::Cmd::run with a scalar command results in splitting on > spaces, which produces the > bad results. > > Instead, since we already have all 4 arguments individually, we should > pass an array reference > to IPC::Cmd::run(). > > The attached patch fixes the problem. Please integrate it into a > future version of CPANPLUS.
Thanks, applied with some tweaks.