Skip Menu |

This queue is for tickets about the HTML-SimpleLinkExtor CPAN distribution.

Report information
The Basics
Id: 46052
Status: resolved
Priority: 0/
Queue: HTML-SimpleLinkExtor
People
Owner: Nobody in particular
Requestors: paul [...] city-fan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.22
Fixed in: (no value)

History Show all quoted text
  Wed May 13 18:10:11 2009 paul [...] city-fan.org - Ticket created
Subject: Test suite failure with HTML-Parser > 3.56
HTML-Parser (the distribution containing HTML::LinkExtor) versions later than 3.56 treat IFRAME content as plain text and hence don't find links within it. This causes test suite failures in HTML-SimpleLinkExtor such as: # Failed test 'Found the right number of links' # at t/absolute_links.t line 28. # got: '2' # expected: '11' # Looks like you failed 1 test of 8. t/absolute_links.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests There are many examples of this on the CPAN testers site. The attached patch close the IFRAMEs in the example files immediately and allows the test suite to pass.
Subject: perl-HTML-SimpleLinkExtor-1.22-iframe.patch
--- HTML-SimpleLinkExtor-1.22/t/example2.html 2008-09-08 02:06:07.000000000 +0100 +++ HTML-SimpleLinkExtor-1.22/t/example2.html 2009-05-13 22:37:29.000000000 +0100 @@ -17,6 +17,7 @@ <iframe class="banner" src="/Images/banners/apress/apress.html" height=68 width="468" scrolling="no" marginwidth="5" marginheight="10" frameborder="0" align="right"> +</iframe> <ul> <li><a href="relative.html">A relative link</a> --- HTML-SimpleLinkExtor-1.22/t/example.html 2008-09-08 02:06:07.000000000 +0100 +++ HTML-SimpleLinkExtor-1.22/t/example.html 2009-05-13 22:41:41.000000000 +0100 @@ -27,6 +27,7 @@ <!-- 1 IFRAME --> <iframe class="banner" src="/Images/banners/apress/apress.html" height=68 width="468" scrolling="no" marginwidth="5" marginheight="10" frameborder="0" align="right"> +</iframe> <ul> <!-- 8 A links -->
  Fri May 15 02:08:15 2009 bdfoy [...] cpan.org - Correspondence added
It's disappointing that HTML::Parser was purposedly broken in this way. The correct fix has to be more than disabling the tests, so I'll have to find a way to restore this functionality. It's really a fix that should be in HTML::Parser though.
  Fri May 15 02:08:16 2009 The RT System itself - Status changed from 'new' to 'open'
  Fri May 15 02:37:32 2009 paul [...] city-fan.org - Correspondence added
On Fri May 15 02:08:15 2009, BDFOY wrote: Show quoted text
> It's disappointing that HTML::Parser was purposedly broken in this way. > The correct fix has to be more than disabling the tests, so I'll have to > find a way to restore this functionality. It's really a fix that should > be in HTML::Parser though.
Yes, I'd have expected HTML::Parser to support a configuration option to be like a browser that didn't support frames, so it could follow the non-frame content rather than the frame content.
  Mon Jun 01 05:06:12 2009 paul [...] city-fan.org - Correspondence added
From: paul [...] city-fan.org
1.23 has resolved the test suite issue but unfortunately drops the manpage for HTML::SimpleLinkExtor - was this intended?
  Mon Jun 01 11:52:39 2009 bdfoy [...] cpan.org - Correspondence added
On Mon Jun 01 05:06:12 2009, paul@city-fan.org wrote: Show quoted text
> 1.23 has resolved the test suite issue but unfortunately drops the > manpage for HTML::SimpleLinkExtor - was this intended?
Yes, that was intended. Please leave this ticket closed by not replying to it. If there is a different issue, open a new ticket.
  Mon Jun 01 11:52:40 2009 bdfoy [...] cpan.org - Status changed from 'open' to 'resolved'