Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Win32-GUI CPAN distribution.

Report information
The Basics
Id: 45984
Status: resolved
Priority: 0/
Queue: Win32-GUI
People
Owner: Nobody in particular
Requestors: kmx [...] volny.cz
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)
Attachments
Win32-GUI-1.06_patch.diff.gz

History Show all quoted text
  Tue May 12 04:11:12 2009 kmx [...] volny.cz - Ticket created
Subject: Test 98_Pod.t fails on strawberry perl
Date: Tue, 12 May 2009 10:10:43 +0200
To: bug-Win32-GUI [...] rt.cpan.org
From: kmx <kmx [...] volny.cz>
Hi, I have experienced some minor problem with test Win32-GUI-1.06\t\98_Pod.t (see the end of this e-mail). This occurs when Test::Pod is installed before Win32::GUI. Tested on strawberry 5.8.9. -- kmx ... D:\strawberry\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib\lib', 'blib\arch')" t/*.t t/01_basic.t ....................... ok t/02_constants.t ................... ok t/02_window.t ...................... ok t/03_button.t ...................... ok t/04_cov.t ......................... ok t/05_AcceleratorTable.t ............ ok t/05_Menu.t ........................ ok t/05_NotifyIcon_01_Constructor.t ... ok t/05_NotifyIcon_02_Change.t ........ ok t/05_NotifyIcon_03_OtherMethods.t .. ok t/05_NotifyIcon_04_Remove.t ........ ok t/05_NotifyIcon_05_DESTROY.t ....... ok t/05_Timer_01_OEM.t ................ ok t/05_Timer_02_NEM.t ................ ok t/05_Timer_03_Interval.t ........... ok t/05_Timer_04_Kill.t ............... ok t/05_Timer_05_DESTROY.t ............ ok t/06_Cursor.t ...................... ok t/06_Icon.t ........................ ok t/50_Font_GetMetrics.t ............. ok t/50_Richedit_GetCharFormat.t ...... ok t/97_Version.t ..................... ok t/98_Pod.t ......................... ok t/99_pod_coverage.t ................ ok All tests successful. Files=24, Tests=457, 21 wallclock secs ( 0.28 usr + 0.14 sys = 0.42 CPU) Result: PASS D:\strawberry\perl\bin\perl.exe "-MExtUtils::Command::MM" "-e" "test_harness(0, '..\blib\lib', '..\blib\arch')" t/*.t t/01_load.t .......... ok t/02_public_api.t .... ok t/03_inline.t ........ ok t/04_new.t ........... ok t/05_newCursor.t ..... ok t/06_newIcon.t ....... ok t/98_pod.t ........... You said to run 0 tests at t/98_pod.t line 16. t/98_pod.t ........... Dubious, test returned 2 (wstat 512, 0x200) No subtests run t/99_pod_coverage.t .. ok Test Summary Report ------------------- t/98_pod.t (Wstat: 512 Tests: 0 Failed: 0) Non-zero exit status: 2 Parse errors: No plan found in TAP output Files=8, Tests=31, 3 wallclock secs ( 0.08 usr + 0.06 sys = 0.14 CPU) Result: FAIL
  Thu Sep 24 15:34:47 2009 kmx [...] cpan.org - Correspondence added
Hi, could you please consider the enclosed patch that skips all POD tests unless the TEST_POD env variable is defined? I know that the right solution is to fix the POD issues, however this patch makes the module at least installable without failing tests. The proposed approach with TEST_POD variable is quite common (I guess). -- kmx
Download Win32-GUI-1.06_patch.diff.gz
application/gzip 1.2k

Message body not shown because it is not plain text.

  Thu Sep 24 15:34:49 2009 The RT System itself - Status changed from 'new' to 'open'
  Fri Apr 13 13:27:44 2012 RURBAN [...] cpan.org - Correspondence added
To fix the 98_pod.t issue (and one more 5.14 issue) use this: --- origsrc/Win32-GUI-1.06/Win32-GUI-Constants/t/10_inherit.t 2006-05- 13 10:39:30.000000000 -0500 +++ src/Win32-GUI-1.06/Win32-GUI-Constants/t/10_inherit.t 2012-04- 13 12:08:21.218750000 -0500 @@ -23,7 +23,7 @@ our @ISA = qw(Win32::GUI::Constants); package main; #use Win32::ABC qw(CW_USEDEFAULT); -Win32::ABC->import qw(CW_USEDEFAULT); # Equililent to use() when package doesn't come from seperate file +Win32::ABC->import ('CW_USEDEFAULT'); # Equililent to use() when package doesn't come from seperate file # Test exporting of default constant can_ok("main", "CW_USEDEFAULT"); --- origsrc/Win32-GUI-1.06/Win32-GUI-Constants/t/98_pod.t 2006-05- 16 13:57:26.000000000 -0500 +++ src/Win32-GUI-1.06/Win32-GUI-Constants/t/98_pod.t 2012-04-13 12:11:27.296875000 -0500 @@ -13,4 +13,4 @@ use Test::More; eval "use Test::Pod 1.14"; plan skip_all => "Test::Pod 1.14 required for testing POD" if $@; plan skip_all => "Pod tests for Win32::GUI::Constants done by core" if $ENV{W32G_CORE}; -all_pod_files_ok(); +all_pod_files_ok(all_pod_files('.')); -- Reini Urban
  Mon Oct 13 09:47:33 2014 kmx [...] cpan.org - Correspondence added
fixed in 1.08
  Mon Oct 13 09:48:23 2014 kmx [...] cpan.org - Status changed from 'open' to 'resolved'