Skip Menu |

This queue is for tickets about the Class-Throwable CPAN distribution.

Report information
The Basics
Id: 45929
Status: resolved
Priority: 0/
Queue: Class-Throwable
People
Owner: Nobody in particular
Requestors: kmx [...] volny.cz
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)
Attachments
Class-Throwable-0.10_01.tar.gz
win32_patch.diff

History Show all quoted text
  Sun May 10 16:27:48 2009 kmx [...] volny.cz - Ticket created
Subject: [PATCH] win32/strawberry perl compatibility
Date: Sun, 10 May 2009 22:27:01 +0200
To: bug-Class-Throwable [...] rt.cpan.org
From: kmx <kmx [...] volny.cz>
diff -u Class-Throwable-0.10/t/10_Class_Throwable_test.t Class-Throwable-0.10_01/t/10_Class_Throwable_test.t --- Class-Throwable-0.10/t/10_Class_Throwable_test.t 2004-12-12 16:44:18.000000000 +0100 +++ Class-Throwable-0.10_01/t/10_Class_Throwable_test.t 2009-05-10 10:30:54.359375000 +0200 @@ -10,7 +10,7 @@ } my $path_seperator = "/"; -$path_seperator = "\\" if $^O eq 'MSWin32'; +# MSWin32 perl works fine with "/" $path_seperator = ":" if $^O eq 'MacOS'; can_ok("Class::Throwable", 'throw'); diff -u Class-Throwable-0.10/t/20_Class_Throwable_subException_test.t Class-Throwable-0.10_01/t/20_Class_Throwable_subException_test.t --- Class-Throwable-0.10/t/20_Class_Throwable_subException_test.t 2004-12-12 16:44:18.000000000 +0100 +++ Class-Throwable-0.10_01/t/20_Class_Throwable_subException_test.t 2009-05-10 10:30:51.125000000 +0200 @@ -10,7 +10,7 @@ } my $path_seperator = "/"; -$path_seperator = "\\" if $^O eq 'MSWin32'; +# MSWin32 perl works fine with "/" $path_seperator = ":" if $^O eq 'MacOS'; eval { diff -u Class-Throwable-0.10/t/35_Class_Throwable_sub_class_test.t Class-Throwable-0.10_01/t/35_Class_Throwable_sub_class_test.t --- Class-Throwable-0.10/t/35_Class_Throwable_sub_class_test.t 2004-12-12 16:44:18.000000000 +0100 +++ Class-Throwable-0.10_01/t/35_Class_Throwable_sub_class_test.t 2009-05-10 10:30:47.375000000 +0200 @@ -12,7 +12,7 @@ } my $path_seperator = "/"; -$path_seperator = "\\" if $^O eq 'MSWin32'; +# MSWin32 perl works fine with "/" $path_seperator = ":" if $^O eq 'MacOS'; eval {
Download Class-Throwable-0.10_01.tar.gz
application/gzip 11k

Message body not shown because it is not plain text.

Hi, please find enclosed simple patch against Class::Throwable v0.10 (as well as the whole patched package). The patch changes just the following test files: - 10_Class_Throwable_test.t - 20_Class_Throwable_subException_test.t - 35_Class_Throwable_sub_class_test.t I have tested it with win32/strawberry perl 5.8.9 and 5.10.0 - in both cases all tests pass. The patch absolutely does not affect any non-Win32 platform. By applying this patch you can close: - http://rt.cpan.org/Public/Bug/Display.html?id=36835 - http://rt.cpan.org/Public/Bug/Display.html?id=28020 -- kmx
  Fri Jul 24 03:53:35 2009 kmx [...] volny.cz - Correspondence added
Subject: Re: [rt.cpan.org #45929] [PATCH] win32/strawberry perl compatibility
Date: Fri, 24 Jul 2009 09:53:12 +0200
To: bug-Class-Throwable [...] rt.cpan.org
From: kmx <kmx [...] volny.cz>
Hi, could you please consider applying the above submitted simple patch? It contains just 3 changed lines. It would be nice to be able to install Class::Throwable on Win32 without failing tests. Thank you. -- kmx
  Fri Jul 24 10:29:26 2009 stevan.little [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #45929] [PATCH] win32/strawberry perl compatibility
Date: Fri, 24 Jul 2009 10:29:02 -0400
To: bug-Class-Throwable [...] rt.cpan.org
From: Stevan Little <stevan.little [...] iinteractive.com>
I am insanely busy with work right now, would you be interested in taking on Co-maint for this module? - Stevan On Jul 24, 2009, at 3:53 AM, kmx via RT wrote: Show quoted text
> Queue: Class-Throwable > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=45929 > > > Hi, > > could you please consider applying the above submitted simple patch? > > It contains just 3 changed lines. > > It would be nice to be able to install Class::Throwable on Win32 > without > failing tests. > > Thank you. > > -- > kmx > >
  Fri Jul 24 10:29:27 2009 The RT System itself - Status changed from 'new' to 'open'
  Sun Jul 26 04:26:50 2009 kmx [...] volny.cz - Correspondence added
Subject: Re: [rt.cpan.org #45929] [PATCH] win32/strawberry perl compatibility
Date: Sun, 26 Jul 2009 10:26:15 +0200
To: bug-Class-Throwable [...] rt.cpan.org
From: kmx <kmx [...] volny.cz>
OK, I have sent a request for my PAUSE account. -- kmx Stevan Little via RT napsal(a): Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=45929 > > > I am insanely busy with work right now, would you be interested in > taking on Co-maint for this module? > > - Stevan
  Sun Jul 26 10:47:29 2009 stevan.little [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #45929] [PATCH] win32/strawberry perl compatibility
Date: Sun, 26 Jul 2009 10:47:07 -0400
To: bug-Class-Throwable [...] rt.cpan.org
From: Stevan Little <stevan.little [...] iinteractive.com>
Excellent, let me know when you get it and I will transfer co-maint. Thanks, - Stevan On Jul 26, 2009, at 4:26 AM, kmx via RT wrote: Show quoted text
> Queue: Class-Throwable > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=45929 > > > OK, I have sent a request for my PAUSE account. > > -- > kmx > > Stevan Little via RT napsal(a):
>> <URL: http://rt.cpan.org/Ticket/Display.html?id=45929 > >> >> I am insanely busy with work right now, would you be interested in >> taking on Co-maint for this module? >> >> - Stevan
>
  Sun Jul 26 11:31:11 2009 kmx [...] volny.cz - Correspondence added
Subject: Re: [rt.cpan.org #45929] [PATCH] win32/strawberry perl compatibility
Date: Sun, 26 Jul 2009 17:30:32 +0200
To: bug-Class-Throwable [...] rt.cpan.org
From: kmx <kmx [...] volny.cz>
My request was just approved, I am on PAUSE as kmx. Stevan Little via RT napsal(a): Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=45929 > > > Excellent, let me know when you get it and I will transfer co-maint. > > Thanks, > > - Stevan >
  Sun Jul 26 12:56:03 2009 stevan.little [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #45929] [PATCH] win32/strawberry perl compatibility
Date: Sun, 26 Jul 2009 12:55:40 -0400
To: bug-Class-Throwable [...] rt.cpan.org
From: Stevan Little <stevan.little [...] iinteractive.com>
You are not co-maintainer of Class::Throwable. Feel free to apply your patches and upload whenever your ready. Thanks much for doing this. - Stevan On Jul 26, 2009, at 11:31 AM, kmx via RT wrote: Show quoted text
> Queue: Class-Throwable > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=45929 > > > My request was just approved, I am on PAUSE as kmx. > > > Stevan Little via RT napsal(a):
>> <URL: http://rt.cpan.org/Ticket/Display.html?id=45929 > >> >> Excellent, let me know when you get it and I will transfer co-maint. >> >> Thanks, >> >> - Stevan >>
>
  Mon Jul 27 00:27:48 2009 kmx [...] volny.cz - Correspondence added
solved in 0.11 -- kmx
  Mon Jul 27 00:27:49 2009 kmx [...] volny.cz - Status changed from 'open' to 'resolved'