Skip Menu |

This queue is for tickets about the Parse-CPAN-Meta CPAN distribution.

Report information
The Basics
Id: 45891
Status: rejected
Priority: 0/
Queue: Parse-CPAN-Meta

People
Owner: Nobody in particular
Requestors: melo [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.05
Fixed in: (no value)



Subject: Parse fails with lists with a single element
Hi, I use Dist::Zilla to generate my META.yml file. The file includes these lines: author: - Pedro Melo <melo@cpan.org> generated_by: Dist::Zilla::Plugin::MetaYaml version 1.091260 Your parser fails to recognize these YAML (generated with YAML::XS) with this message: ERR: Parse::CPAN::Meta does not support the line 'generated_by: Dist::Zilla::Plugin::MetaYaml version 1.091260 Maybe your module could detect the presence of an YAML parser installed and use it, falling back to your code only if need be. Best regards,
Subject: Re: [rt.cpan.org #45891] Parse fails with lists with a single element
Date: Sun, 10 May 2009 00:03:48 +1000
To: bug-Parse-CPAN-Meta [...] rt.cpan.org
From: Adam Kennedy <adamkennedybackup [...] gmail.com>
Unfortunately the problem is more complicated than that. Many YAML parser don't support things that are common in META.yml files so by no means is Parse::CPAN::Meta a "worse" parser that could know to hand off to a "better" parser. Take a look at the following URL for a summary of the problem. http://echo.dagolden.com/~xdg/meta-yaml.html HOWEVER RJBS has commit to my repository, so it should be fairly straight forward for him to add a failing test case to YAML::Tiny/Parse::CPAN::Meta for that sample, and we can fix the actual bug. Note that we'd probably consider this an urgent thing to fix, because any such changes would need to get into the Perl code before the imminent 5.10.1 release. Adam K 2009/5/9 http://www.simplicidade.org/ via RT <bug-Parse-CPAN-Meta@rt.cpan.org>: Show quoted text
> Sat May 09 09:50:07 2009: Request 45891 was acted upon. > Transaction: Ticket created by http://www.simplicidade.org/ >       Queue: Parse-CPAN-Meta >     Subject: Parse fails with lists with a single element >   Broken in: 0.05 >    Severity: Important >       Owner: Nobody >  Requestors: melo@cpan.org >      Status: new >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=45891 > > > > Hi, > > I use Dist::Zilla to generate my META.yml file. The file includes these lines: > > author: > - Pedro Melo <melo@cpan.org> > generated_by: Dist::Zilla::Plugin::MetaYaml version 1.091260 > > Your parser fails to recognize these YAML (generated with YAML::XS) with this message: > > ERR: Parse::CPAN::Meta does not support the line 'generated_by: Dist::Zilla::Plugin::MetaYaml > version 1.091260 > > Maybe your module could detect the presence of an YAML parser installed and use it, falling > back to your code only if need be. > > Best regards, >
Subject: Re: [rt.cpan.org #45891] Parse fails with lists with a single element
Date: Sat, 9 May 2009 15:16:50 +0100
To: bug-Parse-CPAN-Meta [...] rt.cpan.org
From: Pedro Melo <melo [...] cpan.org>
Hi, I've actually came across this while using rjbs Dist::Zilla and made a patch for his Plugin::MetaTests to make sure the Parse::CPAN::Meta understands single author META.yml files: http://github.com/melo/dist-zilla/commit/b44ba01124e7cd45d55947e27b4d4de37b9fca96 I didn't mean to offend with the "better" parser, in any way. Sorry if it sounded harsh. I understand, specially by reading some of your articles, the mess that is parsing META.yml. I'll try to come up with a patch to make Parse::CPAN::Meta understand this case. Best regards, On May 9, 2009, at 3:04 PM, Adam Kennedy via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=45891 > > > Unfortunately the problem is more complicated than that. > > Many YAML parser don't support things that are common in META.yml > files so by no means is Parse::CPAN::Meta a "worse" parser that could > know to hand off to a "better" parser. > > Take a look at the following URL for a summary of the problem. > > http://echo.dagolden.com/~xdg/meta-yaml.html > > HOWEVER > > RJBS has commit to my repository, so it should be fairly straight > forward for him to add a failing test case to > YAML::Tiny/Parse::CPAN::Meta for that sample, and we can fix the > actual bug. > > Note that we'd probably consider this an urgent thing to fix, because > any such changes would need to get into the Perl code before the > imminent 5.10.1 release. > > Adam K > > 2009/5/9 http://www.simplicidade.org/ via RT <bug-Parse-CPAN-Meta@rt.cpan.org
> >:
>> Sat May 09 09:50:07 2009: Request 45891 was acted upon. >> Transaction: Ticket created by http://www.simplicidade.org/ >> Queue: Parse-CPAN-Meta >> Subject: Parse fails with lists with a single element >> Broken in: 0.05 >> Severity: Important >> Owner: Nobody >> Requestors: melo@cpan.org >> Status: new >> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=45891 > >> >> >> Hi, >> >> I use Dist::Zilla to generate my META.yml file. The file includes >> these lines: >> >> author: >> - Pedro Melo <melo@cpan.org> >> generated_by: Dist::Zilla::Plugin::MetaYaml version 1.091260 >> >> Your parser fails to recognize these YAML (generated with YAML::XS) >> with this message: >> >> ERR: Parse::CPAN::Meta does not support the line 'generated_by: >> Dist::Zilla::Plugin::MetaYaml >> version 1.091260 >> >> Maybe your module could detect the presence of an YAML parser >> installed and use it, falling >> back to your code only if need be. >> >> Best regards, >>
>
-- Pedro Melo Blog: http://www.simplicidade.org/notes/ XMPP ID: melo@simplicidade.org Use XMPP!
CC: bug-Parse-CPAN-Meta [...] rt.cpan.org
Subject: Re: [rt.cpan.org #45891] Parse fails with lists with a single element
Date: Sat, 9 May 2009 15:34:34 +0100
To: Pedro Melo <melo [...] cpan.org>
From: Pedro Melo <melo [...] simplicidade.org>
Hi again, I'm going to hide in shame now... This is fixed in version 0.5. The last test of t/03_regression.t coves this scenario. In my defense I can only say that I was working on two machines and one of them had a out-of-date PArse::CPAN::Meta. Sorry for the trouble. -- Pedro Melo Blog: http://www.simplicidade.org/notes/ XMPP ID: melo@simplicidade.org Use XMPP!
Don't worry, we're all just human. :)