Subject: | better tests and Build.PL |
3 more tests for 2 new browsers and 1 old browser.
Build.PL will generate better META.yml.
Build.PL has correct dependencies.
--
Alexandr Ciornii, http://chorny.net
Subject: | Build.PL.patch |
--- Build.PL.dist 2008-09-24 20:19:38.000000000 +0300
+++ Build.PL 2009-05-08 18:34:39.109375000 +0300
@@ -1,3 +1,4 @@
+use 5.006;
use strict;
use warnings;
use Module::Build;
@@ -8,9 +9,12 @@
dist_author => 'Takaaki Mizuno <cpan@takaaki.info>',
dist_version_from => 'lib/HTTP/DetectUserAgent.pm',
requires => {
- 'Test::More' => 0,
- 'version' => 0,
'Class::Accessor' => 0,
+ 'perl' => 5.006,
+ },
+ build_requires => {
+ 'Test::More' => 0,
+ 'Test::Base' => 0,
},
add_to_cleanup => [ 'HTTP-DetectUserAgent-*' ],
);
Subject: | 01.browser.t.patch |
--- 01.browser.t.dist 2008-10-06 13:18:00.000000000 +0300
+++ 01.browser.t 2009-05-08 22:35:07.765625000 +0300
@@ -50,6 +50,15 @@
vendor: "Microsoft"
os: "Windows"
+=== Internet Explorer 8.0
+--- input
+Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 1.1.4322)
+--- expected
+name: "Internet Explorer"
+version: "8.0"
+vendor: "Microsoft"
+os: "Windows"
+
=== Sleipnir
--- input
Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322; .NET CLR 2.0.50727; InfoPath.1) Sleipnir/2.8.0
@@ -77,7 +86,7 @@
vendor: "Apple"
os: "Macintosh"
-=== Chorme
+=== Chrome
--- input
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US) AppleWebKit/525.13 (KHTML, like Gecko) Chrome/0.2.149.27 Safari/525.13
--- expected
@@ -95,6 +104,24 @@
vendor: "Opera"
os: "Windows"
+=== Opera 9.62
+--- input
+Opera/9.62 (Windows NT 5.1; U; ru) Presto/2.1.1
+--- expected
+name: "Opera"
+version: "9.62"
+vendor: "Opera"
+os: "Windows"
+
+=== Opera 6
+--- input
+Mozilla/4.0 (compatible; MSIE 5.0; Windows XP) Opera 6.02 [en]
+--- expected
+name: "Opera"
+version: "6.02"
+vendor: "Opera"
+os: "Windows"
+
=== Firefox
--- input
Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv:1.9.0.2) Gecko/2008091620 Firefox/3.0.2,gzip(gfe),gzip(gfe)
@@ -103,5 +130,3 @@
version: "3.0.2"
vendor: "Mozilla"
os: "Windows"
-
-