Bug #45876 for Class-DBI-Sweet: t/04join.t fails

Fri May 08 17:03:47 2009 gregoa [...] debian.org - Ticket created

Subject:	t/04join.t fails
Date:	Fri, 8 May 2009 23:03:20 +0200
To:	bug-Class-DBI-Sweet [...] rt.cpan.org
From:	gregor herrmann <gregoa [...] debian.org>

Hi, both the Debian Bug Tracker and the CPAN Testers page show that t/04join.t started to fail, probably due to changes in one of the dependencies (SQL::Abstract?): http://bugs.debian.org/527750 http://www.cpantesters.org/show/Class-DBI-Sweet.html#Class-DBI-Sweet-0.09 Please consider looking into this issue. Thanks in advance, gregor, Debian Perl Group -- .''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/ `- NP: Flying Pickets: Les Yeux Revolver

Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

Sat May 09 16:46:47 2009 fred [...] redhotpenguin.com - Correspondence added

Subject:	Re: [rt.cpan.org #45876] t/04join.t fails
Date:	Sat, 09 May 2009 13:46:26 -0700
To:	bug-Class-DBI-Sweet [...] rt.cpan.org
From:	Fred Moyer <fred [...] redhotpenguin.com>

Thanks for bringing this up. Patches welcome. On 5/8/09 2:03 PM, gregor herrmann via RT wrote: Show quoted text

> Fri May 08 17:03:47 2009: Request 45876 was acted upon. > Transaction: Ticket created by gregoa@debian.org > Queue: Class-DBI-Sweet > Subject: t/04join.t fails > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: gregoa@debian.org > Status: new > Ticket<URL: http://rt.cpan.org/Ticket/Display.html?id=45876> > > > Hi, > > both the Debian Bug Tracker and the CPAN Testers page show that > t/04join.t started to fail, probably due to changes in one of the > dependencies (SQL::Abstract?): > > http://bugs.debian.org/527750 > http://www.cpantesters.org/show/Class-DBI-Sweet.html#Class-DBI-Sweet-0.09 > > Please consider looking into this issue. > > Thanks in advance, > gregor, Debian Perl Group

Sat May 09 16:46:48 2009 The RT System itself - Status changed from 'new' to 'open'

Wed Jul 01 11:07:34 2009 gregoa [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #45876] t/04join.t fails
Date:	Wed, 1 Jul 2009 17:07:11 +0200
To:	"fred [...] redhotpenguin.com via RT" <bug-Class-DBI-Sweet [...] rt.cpan.org>
From:	gregor herrmann <gregoa [...] debian.org>

On Sat, 09 May 2009 16:46:48 -0400, fred@redhotpenguin.com via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=45876 > > Thanks for bringing this up. Patches welcome.

Class-DBI-Plugin-AbstractCount has switched to using SQL::Abstract::Test (requires SQLA >= 1.50) for it's tests, maybe that would help for Class-DBI-Sweet too? Cheers, gregor -- .''`. http://info.comodo.priv.at/ -- GPG Key IDs: 0x00F3CFE4, 0x8649AA06 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/ `- NP: Bob Dylan: Someday Baby

Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

Wed Jul 01 13:01:03 2009 fred [...] redhotpenguin.com - Correspondence added

Subject:	Re: [rt.cpan.org #45876] t/04join.t fails
Date:	Wed, 01 Jul 2009 10:00:38 -0700
To:	bug-Class-DBI-Sweet [...] rt.cpan.org
From:	Fred Moyer <fred [...] redhotpenguin.com>

Patches welcome. I'm a heavy DBIx::Class user now and rely on others to submit patches for this module. On 7/1/09 8:07 AM, gregor herrmann via RT wrote: Show quoted text

> Queue: Class-DBI-Sweet > Ticket<URL: http://rt.cpan.org/Ticket/Display.html?id=45876> > > On Sat, 09 May 2009 16:46:48 -0400, fred@redhotpenguin.com via RT wrote: >

>> <URL: https://rt.cpan.org/Ticket/Display.html?id=45876> >> Thanks for bringing this up. Patches welcome.

> > Class-DBI-Plugin-AbstractCount has switched to using > SQL::Abstract::Test (requires SQLA>= 1.50) for it's tests, maybe that > would help for Class-DBI-Sweet too? > > Cheers, > gregor

Mon Aug 03 09:40:54 2009 dam [...] modsoftsys.com - Correspondence added

From:

dam [...] modsoftsys.com

On Wed Jul 01 13:01:03 2009, fred@redhotpenguin.com wrote: Show quoted text

> Patches welcome. I'm a heavy DBIx::Class user now and rely on others to > submit patches for this module.

Please find attached a patch to t/04join.t that adjusts the expected output to the new SQL::Abstract. The patch also bumps SQL::Abstract dependency in Build.PL to 1.55 thanks, dam

--- a/Build.PL (revision 41217) +++ b/Build.PL (working copy) @@ -10,7 +10,7 @@ 'Data::Page' => 0, 'DBI' => 0, 'List::Util' => 0, - 'SQL::Abstract' => 1.17, + 'SQL::Abstract' => 1.55, 'DBD::SQLite' => 1.08 }, dist_abstract => 'lib/Class/DBI/Sweet.pm', --- a/t/04join.t +++ b/t/04join.t @@ -29,7 +29,7 @@ my ($sql) = $cds[0]->_search({ 'artist.n is($sql->{from}, "cd me, artist artist", "FROM statement ok"); -is($sql->{where}, "( artist.name = ? ) AND me.artist = artist.artistid", +is($sql->{where}, "artist.name = ? AND me.artist = artist.artistid", "WHERE clause ok"); cmp_ok($cds[2]->year, '==', 2001, "Last CD returned correctly");

Mon Aug 03 16:45:56 2009 PHRED [...] cpan.org - Correspondence added

My svn update to the old sweet repository is failing. I've the copy I have into github here: http://github.com/redhotpenguin/Class-DBI-Sweet/tree/master Can you take this and run with it? I can push a release if I still have the permissions. On Mon Aug 03 09:40:54 2009, dam@modsoftsys.com wrote: Show quoted text

> On Wed Jul 01 13:01:03 2009, fred@redhotpenguin.com wrote:

> > Patches welcome. I'm a heavy DBIx::Class user now and rely on

others to Show quoted text

> > submit patches for this module.

> > Please find attached a patch to t/04join.t that adjusts the expected > output to the new SQL::Abstract. > > The patch also bumps SQL::Abstract dependency in Build.PL to 1.55 > > thanks, > dam

Mon Aug 03 23:30:29 2009 PHRED [...] cpan.org - Correspondence added

Look for 0.10 coming to CPAN which resolves this.

Mon Aug 03 23:30:32 2009 PHRED [...] cpan.org - Status changed from 'open' to 'resolved'