Bug #45724 for Catalyst-Plugin-Session-Store-FastMmap: Changes in basic.t since 0.08

Tue May 05 03:45:03 2009 kmx [...] volny.cz - Ticket created

Subject:	Changes in basic.t since 0.08
Date:	Tue, 05 May 2009 09:44:36 +0200
To:	bug-Catalyst-Plugin-Session-Store-FastMmap [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

Hi, I would like to ask what was the reason for the following change in basic.t introduced in version 0.08: use Catalyst::Plugin::Session::Test::Store ( backend => "FastMmap", - config => { storage => File::Temp::tempdir( 'sessionstoretestXXXX', CLEANUP => 1 ) . "/storage_file" }, + config => { storage => File::Temp::tempdir( 'sessionstoretestXXXX', CLEANUP => 1 ) }, extra_tests => 1 ); According to documentation: "<storage> Specifies THE FILE to be used for the sharing of session data." thus the above mentioned change does not make a sense. -- kmx

Tue May 05 03:59:46 2009 bobtfish [...] bobtfish.net - Correspondence added

On Tue May 05 03:45:03 2009, kmx@volny.cz wrote: Show quoted text

> Hi, > > I would like to ask what was the reason for the following change in > basic.t introduced in version 0.08:

Looking through the revision log: http://dev.catalyst.perl.org/svnweb/Catalyst/log/trunk/Catalyst-Plugin-Session-Store-FastMmap/ I can't see that code having ever been committed. However, it looks more correct to me, therefore I have committed it as r10006, and it'll be back in the next release. Cheers t0m

Tue May 05 03:59:47 2009 The RT System itself - Status changed from 'new' to 'open'

Tue May 05 03:59:48 2009 bobtfish [...] bobtfish.net - Status changed from 'open' to 'resolved'

Tue May 05 15:53:14 2009 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #45724] Changes in basic.t since 0.08
Date:	Tue, 05 May 2009 21:52:45 +0200
To:	bug-Catalyst-Plugin-Session-Store-FastMmap [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

If I can propose a little change I would prefer this way that seems to me more robust: config => { storage => File::Spec->tmpdir() . "/sessionstoretest_" . int(rand(9999)) . "_$$" }, it creates a file named "sessionstoretest_$random_$pid" in the first writable temporary directory. Tested just on Win32/strawberry; however I expect no problems with other platforms. -- kmx

Tue May 05 15:53:14 2009 The RT System itself - Status changed from 'resolved' to 'open'

Tue May 05 18:58:37 2009 bobtfish [...] bobtfish.net - Correspondence added

Subject:	Re: [rt.cpan.org #45724] Changes in basic.t since 0.08
Date:	Tue, 5 May 2009 23:56:08 +0100
To:	bug-Catalyst-Plugin-Session-Store-FastMmap [...] rt.cpan.org
From:	Tomas Doran <bobtfish [...] bobtfish.net>

On 5 May 2009, at 20:53, kmx via RT wrote: Show quoted text

> Queue: Catalyst-Plugin-Session-Store-FastMmap > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=45724 > > > If I can propose a little change I would prefer this way that seems to > me more robust: >

YES. Please turn up in irc for a short while, and I'll sort you out a commit bit and co-maint. Cheers t0m

Sat Jun 13 22:52:32 2009 karman [...] cpan.org - Correspondence added

can we close this one?

Sun Jun 14 11:19:59 2009 bobtfish [...] bobtfish.net - Taken

Sun Jun 14 11:20:18 2009 bobtfish [...] bobtfish.net - Status changed from 'open' to 'resolved'

Sun Jun 14 11:20:19 2009 bobtfish [...] bobtfish.net - Broken in 0.08 added

Sun Jun 14 11:20:19 2009 bobtfish [...] bobtfish.net - Fixed in 0.10 added