Bug #45647 for MP3-Tag:

Sat May 02 13:36:26 2009 MAXB [...] cpan.org - Ticket created

CC:	thg [...] users.sourceforge.net, ilyaz [...] cpan.org, max [...] warped.org

There is a bug in ID3v2.pm that gives me this error : Can't call method "flags" on unblessed reference at /usr/local/lib/perl5/site_perl/5.10.0/MP3/Tag/ID3v2.pm line 582. The problem is on this line : $data = pack("N", length($data)) . compress $data unless $frame->flags->{unchanged}; It should like this : $data = pack("N", length($data)) . compress $data unless $frame->{flags}->{unchanged}; The scenario where I found it was an MP3 that already had an image embedded for iTunes in 2.4 format. Cheers, -m

Mon May 04 16:37:16 2009 nospam-abuse [...] ilyaz.org - Correspondence added

CC:	undisclosed-recipients: ;
Subject:	Re: [rt.cpan.org #45647]
Date:	Mon, 4 May 2009 13:36:53 -0700
To:	Max Baker via RT <bug-MP3-Tag [...] rt.cpan.org>
From:	Ilya Zakharevich <nospam-abuse [...] ilyaz.org>

On Sat, May 02, 2009 at 01:36:27PM -0400, Max Baker via RT wrote: Show quoted text

> There is a bug in ID3v2.pm that gives me this error : > Can't call method "flags" on unblessed reference at > /usr/local/lib/perl5/site_perl/5.10.0/MP3/Tag/ID3v2.pm line 582. > > The problem is on this line : > > $data = pack("N", length($data)) . compress $data > unless $frame->flags->{unchanged}; > > It should like this : > > $data = pack("N", length($data)) . compress $data > unless $frame->{flags}->{unchanged};

[This is not my code] There is a major problem with this approach - ...->{unchanged} seems to be never modified... Can you edit the frame successfully? You are in the position to fix all these branches. ;-) [Hmm, maybe `unchanged' is 1 on frames coming from a TAG, but is not defined on frames inserted by user?] Show quoted text

> The scenario where I found it was an MP3 that already had an image > embedded for iTunes in 2.4 format.

BTW, does the image extract OK (I never tested compression)? mp3info2 -F "APIC > output.jpeg" foo.mp3 and view output.jpeg? Thanks, Ilya

Mon May 04 16:37:16 2009 The RT System itself - Status changed from 'new' to 'open'