Skip Menu |

This queue is for tickets about the MP3-Tag CPAN distribution.

Report information
The Basics
Id: 45635
Status: open
Priority: 0/
Queue: MP3-Tag
People
Owner: Nobody in particular
Requestors: RBOWES [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Critical
Broken in: 1.00
Fixed in: (no value)

History Show all quoted text
  Fri May 01 18:41:28 2009 RBOWES [...] cpan.org - Ticket created
Subject: Won't install because of failed tests
Hi, There seem to be some issues with the CDDB tests in 1.00. The following patch enables them to pass OK, but I suspect this is not the answer - you appear to be using several CDDB files in the tests, but the distribution only has one. Anyway, here's the patch: --- MP3-Tag-1.00.orig/t/mp3tag.t 2008-10-24 02:25:42.000000000 +0100 +++ MP3-Tag-1.00/t/mp3tag.t 2009-05-01 23:39:50.178952232 +0100 @@ -215,7 +216,7 @@ # print STDERR "# cT=", $mp3->comment_track, "\n"; ok($mp3 && $mp3->comment_track eq 'comment8', "comment_track with removal"); -ok(MP3::Tag->config('cddb_files', qw(cddb.tmp1 cddb.tmp cddb.tmp2)), "Configuring2 list of cddb_files"); +ok(MP3::Tag->config('cddb_files', qw(cddb.tm)), "Configuring2 list of cddb_files"); open NH, '>audio07.mp3' or warn; close NH; @@ -225,7 +227,7 @@ ok($mp3 && $mp3->album eq 'Ancient Voices', "Album via CDDB_File"); ok($mp3 && $mp3->year eq '1234', "Year via CDDB_File"); ok($mp3 && $mp3->comment eq 'comment7; Fake entry', "Comment via CDDB_File"); -ok($mp3 && $mp3->genre eq 'A special genre', "Genre via CDDB_File"); +ok($mp3 && $mp3->genre eq 'Vocal', "Genre via CDDB_File"); ok($mp3 && $mp3->track eq '7', "Track no with CDDB_File");
  Mon May 04 16:25:09 2009 nospam-abuse [...] ilyaz.org - Correspondence added
CC: undisclosed-recipients: ;
Subject: Re: [rt.cpan.org #45635] Won't install because of failed tests
Date: Mon, 4 May 2009 13:24:35 -0700
To: Robin Bowes via RT <bug-MP3-Tag [...] rt.cpan.org>
From: Ilya Zakharevich <nospam-abuse [...] ilyaz.org>
On Fri, May 01, 2009 at 06:41:28PM -0400, Robin Bowes via RT wrote: Show quoted text
> There seem to be some issues with the CDDB tests in 1.00. > > The following patch enables them to pass OK, but I suspect this is not > the answer - you appear to be using several CDDB files in the tests, but > the distribution only has one.
Thanks, fixed in my copy. Yours, Ilya
  Mon May 04 16:25:10 2009 The RT System itself - Status changed from 'new' to 'open'
  Mon May 04 16:28:45 2009 robin [...] robinbowes.com - Correspondence added
CC: RBOWES [...] cpan.org
Subject: Re: [rt.cpan.org #45635] Won't install because of failed tests
Date: Mon, 04 May 2009 21:27:57 +0100
To: bug-MP3-Tag [...] rt.cpan.org
From: Robin Bowes <robin [...] robinbowes.com>
Ilya Zakharevich via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=45635 > > > On Fri, May 01, 2009 at 06:41:28PM -0400, Robin Bowes via RT wrote:
>> There seem to be some issues with the CDDB tests in 1.00. >> >> The following patch enables them to pass OK, but I suspect this is not >> the answer - you appear to be using several CDDB files in the tests, but >> the distribution only has one.
> > Thanks, fixed in my copy.
Out of interest, how did you fix it? And when will you roll a fixed release? Thanks, R. -- NOBODY expects the Spanish Inquisition! Our chief weapon is surprise...surprise and fear...fear and surprise.... Our two weapons are fear and surprise...and ruthless efficiency.... Our *three* weapons are fear, surprise, and ruthless efficiency...and an almost fanatical devotion to the Pope.... Our *four*...no... *Amongst* our weapons.... Amongst our weaponry...are such elements as fear, surprise.... I'll come in again.
  Mon May 04 16:42:34 2009 nospam-abuse [...] ilyaz.org - Correspondence added
CC: undisclosed-recipients: ;
Subject: Re: [rt.cpan.org #45635] Won't install because of failed tests
Date: Mon, 4 May 2009 13:42:11 -0700
To: Robin Bowes via RT <bug-MP3-Tag [...] rt.cpan.org>
From: Ilya Zakharevich <nospam-abuse [...] ilyaz.org>
On Mon, May 04, 2009 at 04:28:45PM -0400, Robin Bowes via RT wrote: Show quoted text
> > Thanks, fixed in my copy.
> > Out of interest, how did you fix it? And when will you roll a fixed release?
I still have the missing file in the build directory. So I just added the accidentally erased line to MANIFEST. And: no promises... Yours, Ilya