Skip Menu |

This queue is for tickets about the Text-VimColor CPAN distribution.

Report information
The Basics
Id: 45623
Status: resolved
Priority: 0/
Queue: Text-VimColor
People
Owner: Nobody in particular
Requestors: hinrik.sig [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: (no value)
Fixed in: 0.12

History Show all quoted text
  Fri May 01 10:56:10 2009 hinrik.sig [...] gmail.com - Ticket created
Subject: Improve performance by adding -n to vim_options
I have found that adding "-n" (no swapfile) to the vim options provides a noticable speed improvement. It shaved two seconds (5.5s to 3.5s) off the generation time for a modestly sized input file highlighted by a rather heavy syntax file. See supplied patch.
Subject: vimcolor.patch
diff -ru Text-VimColor-0.11/lib/Text/VimColor.pm Text-VimColor-0.11-patched/lib/Text/VimColor.pm --- Text-VimColor-0.11/lib/Text/VimColor.pm 2006-02-19 19:31:33.000000000 +0000 +++ Text-VimColor-0.11-patched/lib/Text/VimColor.pm 2009-05-01 14:51:20.000000000 +0000 @@ -14,7 +14,7 @@ our $VERSION = '0.11'; our $VIM_COMMAND = 'vim'; -our @VIM_OPTIONS = (qw( -RXZ -i NONE -u NONE -N ), "+set nomodeline"); +our @VIM_OPTIONS = (qw( -RXZ -i NONE -u NONE -N -n ), "+set nomodeline"); our $NAMESPACE_ID = 'http://ns.laxan.com/text-vimcolor/1'; our %VIM_LET = ( @@ -565,7 +565,7 @@ A reference to an array of options to pass to Vim. The default options are: - qw( -RXZ -i NONE -u NONE -N ) + qw( -RXZ -i NONE -u NONE -N -n ), "+set nomodeline" =item vim_let
  Fri May 01 11:01:44 2009 hinrik.sig [...] gmail.com - Correspondence added
I updated the patch. It removes an item from the BUGS heading relating to previously existing swapfiles, which should be fixed with my patch.
diff -ru Text-VimColor-0.11/lib/Text/VimColor.pm Text-VimColor-0.11-patched/lib/Text/VimColor.pm --- Text-VimColor-0.11/lib/Text/VimColor.pm 2009-05-01 14:59:57.000000000 +0000 +++ Text-VimColor-0.11-patched/lib/Text/VimColor.pm 2009-05-01 14:51:20.000000000 +0000 @@ -14,7 +14,7 @@ our $VERSION = '0.11'; our $VIM_COMMAND = 'vim'; -our @VIM_OPTIONS = (qw( -RXZ -i NONE -u NONE -N ), "+set nomodeline"); +our @VIM_OPTIONS = (qw( -RXZ -i NONE -u NONE -N -n ), "+set nomodeline"); our $NAMESPACE_ID = 'http://ns.laxan.com/text-vimcolor/1'; our %VIM_LET = ( @@ -565,7 +565,7 @@ A reference to an array of options to pass to Vim. The default options are: - qw( -RXZ -i NONE -u NONE -N ) + qw( -RXZ -i NONE -u NONE -N -n ), "+set nomodeline" =item vim_let @@ -795,6 +795,11 @@ =item * +Things can break if there is already a Vim swapfile, but sometimes it +seems to work. + +=item * + There should be a way of getting a DOM object back instead of an XML string. =item *
  Fri May 01 11:01:45 2009 hinrik.sig [...] gmail.com - Status changed from 'new' to 'open'
  Fri May 01 11:04:25 2009 hinrik.sig [...] gmail.com - Correspondence added
Bah, made an error. Here is the right patch.
diff -ru Text-VimColor-0.11/lib/Text/VimColor.pm Text-VimColor-0.11-patched/lib/Text/VimColor.pm --- Text-VimColor-0.11/lib/Text/VimColor.pm 2009-05-01 15:03:11.000000000 +0000 +++ Text-VimColor-0.11-patched/lib/Text/VimColor.pm 2009-05-01 15:03:36.000000000 +0000 @@ -14,7 +14,7 @@ our $VERSION = '0.11'; our $VIM_COMMAND = 'vim'; -our @VIM_OPTIONS = (qw( -RXZ -i NONE -u NONE -N ), "+set nomodeline"); +our @VIM_OPTIONS = (qw( -RXZ -i NONE -u NONE -N -n ), "+set nomodeline"); our $NAMESPACE_ID = 'http://ns.laxan.com/text-vimcolor/1'; our %VIM_LET = ( @@ -565,7 +565,7 @@ A reference to an array of options to pass to Vim. The default options are: - qw( -RXZ -i NONE -u NONE -N ) + qw( -RXZ -i NONE -u NONE -N -n ), "+set nomodeline" =item vim_let @@ -795,11 +795,6 @@ =item * -Things can break if there is already a Vim swapfile, but sometimes it -seems to work. - -=item * - There should be a way of getting a DOM object back instead of an XML string. =item *
  Thu Oct 20 10:42:33 2011 RWSTAUNER [...] cpan.org - Fixed in 0.12 added
  Thu Oct 20 10:42:33 2011 RWSTAUNER [...] cpan.org - Correspondence added
I was granted co-maint by the PAUSE admins and have merged this. Thank you very much!
  Thu Oct 20 10:42:33 2011 RWSTAUNER [...] cpan.org - Status changed from 'open' to 'resolved'