Bug #45599 for Tk: Problem with SelectionGet

here is a patch against subversion C:\devel\Tk\pTk\mTk\win\tkWinClipboard.c Seems to work here (Strawbwerry) - all tests pass. Could anybody review and confirm? Cheers, Christoph Lamprecht

Index: tkWinClipboard.c =================================================================== --- tkWinClipboard.c (revision 12718) +++ tkWinClipboard.c (working copy) @@ -146,23 +146,28 @@ /* * Translate CR/LF to LF. */ - + + int string_length = 0; + data = destPtr = Tcl_DStringValue(&ds); while (*data) { if (data[0] == '\r' && data[1] == '\n') { data++; } else { *destPtr++ = *data++; + string_length ++; } } + + Tcl_DStringTrunc(&ds, string_length); + *destPtr = '\0'; /* * Pass the data off to the selection procedure. */ - result = (*proc)(clientData, interp, (long *) Tcl_DStringValue(&ds), - Tcl_DStringLength(&ds),8,target,tkwin); + Tcl_DStringLength(&ds),8,target,tkwin); Tcl_DStringFree(&ds); CloseClipboard(); return result;

Slaven_Rezic via RT schrieb: Show quoted text
Please find attached a small test program. For best results, I suggest that you use a text with several short lines (gives much garbage), followed by a long line (gives a nearly correct newline count in the test, due to few newlines in the garbage). Usage: put the text to the clipboard, then start the test script. For obvious reasons, this error doesn't exist on Linux. HTH Klaus

use strict; use Tk; my $mw = MainWindow->new; my $sel = $mw->SelectionGet(-selection => 'CLIPBOARD'); #=for test print "No. of Newlines (incl. those in the garbage) ", $sel =~ tr/\n/\n/, "\n"; print "\nContents of selection +$sel+\n"; printf "Contents in hex:\n%v.2x\n", $sel; # Remove garbage at end $sel =~ s/\0.*//s; print "\n", 'Now removed garbage at end by $sel =~ s/\0.*//s;', "\n"; #=for test print "\nContents of selection +$sel+\n"; printf "Contents in hex:\n%v.2x\n", $sel; =cut MainLoop;