Skip Menu |

This queue is for tickets about the Authen-CAS-Client CPAN distribution.

Report information
The Basics
Id: 45553
Status: resolved
Priority: 0/
Queue: Authen-CAS-Client

People
Owner: Nobody in particular
Requestors: agostini [...] univ-metz.fr
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.03
Fixed in: 0.04



Subject: missing dependence on Crypt::SSLeay
Crypt::SSLeay is an needed dependence else if you use CAS on fatal mode you will found this error messages Authen::CAS::Client::Response::Error=HASH(0x8dd6a80)
Le Mer. Avr. 29 06:48:26 2009, YVESAGO a écrit : Show quoted text
> Crypt::SSLeay is a needed dependence > else if you use CAS on fatal mode you will found this error messages > Authen::CAS::Client::Response::Error=HASH(0x8dd6a80)
In fact it's not really needed by Authen::CAS::Client but rather by applications that will use it, as - in usual work - connections with CAS server will use https. Maybe it's only need a small notice in pod. Thank you and sorry for the noise.
On Thu Apr 30 02:34:18 2009, YVESAGO wrote: Show quoted text
> > Authen::CAS::Client::Response::Error=HASH(0x8dd6a80)
> > In fact it's not really needed by Authen::CAS::Client but rather by > applications that will use it, as - in usual work - connections with CAS > server will use https. > Maybe it's only need a small notice in pod. > > Thank you and sorry for the noise.
I was able to whip up a quick test case that duplicates this issue. Even though it's not directly an Authen::CAS::Client issue, the error should still be better. I'll see if I can work something out that will provide more information to anyone using this module. Thanks for the report!
Can you apply the following patch and see if this resolves the issue for you? If that works, I'll fold it into a new dist for CPAN. Thanks.
Index: t/04-fatal.t =================================================================== --- t/04-fatal.t (revision 29) +++ t/04-fatal.t (working copy) @@ -2,7 +2,7 @@ use lib '.'; -use Test::More tests => 2; +use Test::More tests => 1; use t::MockUserAgent; use Authen::CAS::Client; @@ -16,5 +16,4 @@ $mock->_response( 404, 'Not found' ); eval { $cas->validate( 'S', 'T' ) }; -ok( UNIVERSAL::isa( $@, 'Authen::CAS::Client::Response::Error' ), "fatal" ); -like( $@->error(), qr/^HTTP request failed: \d+: / ); +like( $@, qr/^HTTP request failed: \d+: / ); Index: lib/Authen/CAS/Client.pm =================================================================== --- lib/Authen/CAS/Client.pm (revision 29) +++ lib/Authen/CAS/Client.pm (working copy) @@ -13,7 +13,7 @@ use XML::LibXML; use Authen::CAS::Client::Response; -our $VERSION = '0.03'; +our $VERSION = '0.03_01'; #====================================================================== # constructor @@ -39,11 +39,10 @@ sub _error { my ( $self, $error ) = @_; - my $response = Authen::CAS::Client::Response::Error->new( error => $error ); - die $response + die $error if $self->{_fatal}; - $response; + Authen::CAS::Client::Response::Error->new( error => $error ); } sub _parse_auth_response { @@ -369,11 +368,10 @@ =item * fatal =E<gt> $BOOLEAN -If this argument is true, the CAS client will C<die()> with an -C<Authen::CAS::Client::Response::Error> object whenever an error -occurs. Otherwise an C<Authen::CAS::Client::Response::Error> -object is returned, instead. See L<Authen::CAS::Client::Response> -for more detail on response objects. +If this argument is true, the CAS client will C<die()> when an error +occurs and C<$@> will contain the error message. Otherwise an +C<Authen::CAS::Client::Response::Error> object will be returned. See +L<Authen::CAS::Client::Response> for more detail on response objects. =back @@ -515,7 +513,7 @@ =head1 COPYRIGHT -Copyright (c) 2007, 2008, jason hord +Copyright (c) 2007-2009, jason hord All rights reserved.
Subject: Re: [rt.cpan.org #45553] missing dependence on Crypt::SSLeay
Date: Mon, 04 May 2009 16:45:16 +0200
To: bug-Authen-CAS-Client [...] rt.cpan.org
From: Yves Agostini <agostini [...] univ-metz.fr>
Le vendredi 01 mai 2009 à 15:27 -0400, jason hord via RT a écrit : Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=45553 > > > Can you apply the following patch and see if this resolves the issue for > you? If that works, I'll fold it into a new dist for CPAN. Thanks.
Perfect, I have a lovely : HTTP request failed: 501: Protocol scheme 'https' is not supported (Crypt::SSLeay not installed) at /usr/share/perl5/Authen/CAS/Client.pm line 42. Thanks very much -- --------------------------------------------------------------- AGOSTINI Yves CRI - Université Paul Verlaine - Metz agostini@univ-metz.fr http://www.crium.univ-metz.fr tel: 03 87 31 52 63 fax: 03 87 31 53 33 PGP: 842CC261
On Mon May 04 10:45:38 2009, YVESAGO wrote: Show quoted text
> > Perfect, I have a lovely : > > HTTP request failed: 501: Protocol scheme 'https' is not supported > (Crypt::SSLeay not installed) at /usr/share/perl5/Authen/CAS/Client.pm > line 42. > > Thanks very much >
I have uploaded 0.04 to CPAN which fixes this issue. Again, thanks for reporting it.