Skip Menu |

This queue is for tickets about the Catalyst-View-GD-Barcode-QRcode CPAN distribution.

Report information
The Basics
Id: 45460
Status: resolved
Priority: 0/
Queue: Catalyst-View-GD-Barcode-QRcode

People
Owner: Nobody in particular
Requestors: ZARQUON [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in:
  • 0.01
  • 0.02
  • 0.03
  • 0.04
Fixed in: (no value)



This view needs to be updated to work with Catalyst 5.8 Here's a patch (attached)
Subject: patch.diff
diff --git a/Makefile.PL b/Makefile.PL index 66122e5..0647062 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -10,5 +10,6 @@ WriteMakefile( 'Test::Simple' => 0.44, 'Catalyst' => 5.5, 'GD::Barcode::QRcode' => 0.01, + 'MRO::Compat', }, ); diff --git a/lib/Catalyst/View/GD/Barcode/QRcode.pm b/lib/Catalyst/View/GD/Barcode/QRcode.pm index dd04873..a3c1107 100644 --- a/lib/Catalyst/View/GD/Barcode/QRcode.pm +++ b/lib/Catalyst/View/GD/Barcode/QRcode.pm @@ -2,6 +2,7 @@ package Catalyst::View::GD::Barcode::QRcode; use strict; use warnings; +use MRO::Compat; our $VERSION = '0.04'; @@ -14,8 +15,9 @@ use GD::Barcode::QRcode; __PACKAGE__->mk_accessors(qw( ecc version module_size img_type )); sub new { - my ($class, $c, $args) = @_; - my $self = $class->NEXT::new($c); + my ($self) = shift; + my ($c, $args) = @_; + my $self = $self->next::method(@_); for my $field (keys %$args) { if ($self->can($field)) { @@ -24,6 +26,7 @@ sub new { $c->log->debug("Unknown config parameter $field") if $c->debug; } } + return $self; } sub process { @@ -33,7 +36,7 @@ sub process { my $ecc = $conf->{ecc} || $self->ecc || 'M'; my $version = $conf->{version} || $self->version || 4; - my $module_size = $conf->{module_size} || $self->module_size || 1; + my $module_size = $conf->{module_size} || $self->module_size || 4; my $img_type = $conf->{img_type} || $self->img_type || 'png'; my $text = $c->stash->{qrcode};
Applied patch and fixed on 0.05.