Bug #45450 for IPC-SharedCache: Tests fail with newer IPC::ShareLite

Sun Apr 26 14:42:44 2009 gregoa [...] debian.org - Ticket created

Subject:	Tests fail with newer IPC::ShareLite
Date:	Sun, 26 Apr 2009 20:42:17 +0200
To:	bug-IPC-SharedCache [...] rt.cpan.org
From:	gregor herrmann <gregoa [...] debian.org>

Hi, the test suite fails with newer versions of IPC::ShareLite, cf. http://bugs.debian.org/525711 or http://www.cpantesters.org/show/IPC-SharedCache.html Please consider looking into this issue. Cheers, gregor, Debian Perl Group -- .''`. Home: http://info.comodo.priv.at/{,blog/} / GPG Key ID: 0x00F3CFE4 : :' : Debian GNU/Linux user, admin, & developer - http://www.debian.org/ `. `' Member of VIBE!AT, SPI Inc., fellow of FSFE | http://got.to/quote/ `- NP: Tom Waits: I Hope That I Don't Fall in Love with You

Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

Sun Apr 26 16:24:20 2009 ntyni [...] debian.org - Correspondence added

Subject:	[rt.cpan.org #45450] Tests fail with newer IPC::ShareLite
Date:	Sun, 26 Apr 2009 23:23:51 +0300
To:	bug-IPC-SharedCache [...] rt.cpan.org
From:	Niko Tyni <ntyni [...] debian.org>

On Sun, Apr 26, 2009 at 08:39:30PM +0200, gregor herrmann wrote: Show quoted text

> On Sun, 26 Apr 2009 10:43:37 -0700, Daniel Schepler wrote: >

> > /usr/bin/make test > > make[1]: Entering directory `/tmp/buildd/libipc-sharedcache-perl-1.3' > > PERL_DL_NONLAZY=1 /usr/bin/perl "-Iblib/lib" "-Iblib/arch" test.pl > > 1..9 > > ok 1 > > Failed to create share at blib/lib/IPC/SharedCache.pm line 941

Show quoted text

> Confirmed. > The test failures can also be seen at > http://www.cpantesters.org/show/IPC-SharedCache.html#IPC-SharedCache-1.3

This is caused by this change between IPC::ShareLite 0.13 and 0.17: -The constructor returns the undefined value on error. +The constructor croaks on error. [...] $self->{share} = new_share( $self->{key}, $self->{size}, $self->{flags} ) - or return undef; + or croak "Failed to create share"; The attached simple-minded patch wraps the IPC::ShareLite->new() calls inside eval {} blocks. This makes the tests pass for me with both libipc-sharelite-perl 0.13-1+b1 and 0.17-1. The code probably should probably report the $@ value on failure or something like that, but I'm leaving that for you to decide. Thanks for IPC::SharedCache, -- Niko Tyni ntyni@debian.org

Message body is not shown because sender requested not to inline it.

Sun Apr 26 16:24:21 2009 The RT System itself - Status changed from 'new' to 'open'