Bug #45437 for MooseX-Method-Signatures: Typos in documentation

Sun Apr 26 09:40:44 2009 kraai [...] ftbfs.org - Ticket created

Subject:

Typos in documentation

There are a few typos in the MooseX::Method::Signatures POD: * "specifically" is misspelled "specificly" * "surprisingly" is misspelled "surprisnigly" Also, in the Complex Example section, there isn't a comma after the first non-invocant argument, which I think is incorrect.

Subject:

typo-patch

Download typo-patch
application/octet-stream 1.3k

Message body not shown because it is not plain text.

Sun Apr 26 10:18:47 2009 rafl [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #45437] Typos in documentation
Date:	Sun, 26 Apr 2009 16:17:50 +0200
To:	Matt Kraai via RT <bug-MooseX-Method-Signatures [...] rt.cpan.org>
From:	Florian Ragwitz <rafl [...] debian.org>

Hi Matt, On Sun, Apr 26, 2009 at 09:40:46AM -0400, Matt Kraai via RT wrote: Show quoted text

> There are a few typos in the MooseX::Method::Signatures POD: > > * "specifically" is misspelled "specificly" > * "surprisingly" is misspelled "surprisnigly"

Right. Thank you. Show quoted text

> Also, in the Complex Example section, there isn't a comma after the > first non-invocant argument, which I think is incorrect.

You're correct. Thanks for the patch. The repositories for most of my modules, including MooseX::Method::Signatures and MooseX::Declare are available from http://github.com/rafl/ - in case you prefer working directly on the latest version of the code. You can also use github to create a fork and commit your fixes to that, which makes it easier for me to pull them in and also preserves authorship information. If you don't like that and prefer to send normal patches, please say so and I'll go ahead and commit your change. Thanks for your contributions. -- BOFH excuse #425: stop bit received

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Sun Apr 26 10:18:48 2009 The RT System itself - Status changed from 'new' to 'open'

Sun Apr 26 11:03:03 2009 kraai [...] ftbfs.org - Correspondence added

Subject:	Re: [rt.cpan.org #45437] Typos in documentation
Date:	Sun, 26 Apr 2009 08:01:16 -0700
To:	Florian Ragwitz via RT <bug-MooseX-Method-Signatures [...] rt.cpan.org>
From:	Matt Kraai <kraai [...] ftbfs.org>

On Sun, Apr 26, 2009 at 10:18:48AM -0400, Florian Ragwitz via RT wrote: Show quoted text

> Thanks for the patch. The repositories for most of my modules, including > MooseX::Method::Signatures and MooseX::Declare are available from > http://github.com/rafl/ - in case you prefer working directly on the > latest version of the code. You can also use github to create a fork and > commit your fixes to that, which makes it easier for me to pull them in > and also preserves authorship information.

Thanks for the information. I'd noticed the Git repository via the information on MooseX-Method-Signatures page on search.cpan.org, so I prepared the patch using Git. I didn't commit the changes and use format-patch to create the patch, though. I've attached a version that I created by doing so. Show quoted text

> If you don't like that and prefer to send normal patches, please say so > and I'll go ahead and commit your change.

I'd prefer not to create an account and repositories on github since it's not a free network service. -- Matt http://ftbfs.org/

Message body is not shown because sender requested not to inline it.

Sun Apr 26 11:12:24 2009 rafl [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #45437] Typos in documentation
Date:	Sun, 26 Apr 2009 17:11:05 +0200
To:	Matt Kraai via RT <bug-MooseX-Method-Signatures [...] rt.cpan.org>
From:	Florian Ragwitz <rafl [...] debian.org>

On Sun, Apr 26, 2009 at 11:03:04AM -0400, Matt Kraai via RT wrote: Show quoted text

> I've attached a version that I created by doing so.

Great, thank you. Applied and pushed. Show quoted text

> > If you don't like that and prefer to send normal patches, please say so > > and I'll go ahead and commit your change.

> > I'd prefer not to create an account and repositories on github since > it's not a free network service.

Fair enough. Note that you might as well push to a repository anywhere else and just let us know the repository url to pull from, if you don't like using github. -- BOFH excuse #101: Collapsed Backbone

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Sun Apr 26 11:46:06 2009 kraai [...] ftbfs.org - Correspondence added

Subject:	Re: [rt.cpan.org #45437] Typos in documentation
Date:	Sun, 26 Apr 2009 08:44:21 -0700
To:	Florian Ragwitz via RT <bug-MooseX-Method-Signatures [...] rt.cpan.org>
From:	Matt Kraai <kraai [...] ftbfs.org>

On Sun, Apr 26, 2009 at 11:12:26AM -0400, Florian Ragwitz via RT wrote: Show quoted text

> On Sun, Apr 26, 2009 at 11:03:04AM -0400, Matt Kraai via RT wrote:

> > I've attached a version that I created by doing so.

> > Great, thank you. Applied and pushed.

Thanks. Show quoted text

> > > If you don't like that and prefer to send normal patches, please say so > > > and I'll go ahead and commit your change.

> > > > I'd prefer not to create an account and repositories on github since > > it's not a free network service.

> > Fair enough. > > Note that you might as well push to a repository anywhere else and just > let us know the repository url to pull from, if you don't like using > github.

I've made one more typo fix and published it in a repository at git://ftbfs.org/git/moosex-method-signatures -- Matt http://ftbfs.org/

Sun Apr 26 11:50:06 2009 rafl [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #45437] Typos in documentation
Date:	Sun, 26 Apr 2009 17:49:01 +0200
To:	Matt Kraai via RT <bug-MooseX-Method-Signatures [...] rt.cpan.org>
From:	Florian Ragwitz <rafl [...] debian.org>

On Sun, Apr 26, 2009 at 11:46:08AM -0400, Matt Kraai via RT wrote: Show quoted text

> I've made one more typo fix and published it in a repository at > > git://ftbfs.org/git/moosex-method-signatures

Sweet. Thanks -- BOFH excuse #445: Browser's cookie is corrupted -- someone's been nibbling on it.

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Fri May 01 02:25:00 2009 rafl [...] debian.org - Status changed from 'open' to 'resolved'