Bug #45409 for HTML-FormFu:

Fri Apr 24 19:24:18 2009 rod.taylor [...] gmail.com - Ticket created

"when" for a checkbox field does not honour "not" when the checkbox has not been clicked. When the checkbox value is not clicked (!defined) then the constraint is still skipped despite the "not" inversion. Simple one line patch below to correct this issue. - type: Text name: fieldname constraints: - type: Required when: field: some_checkbox values: ['it_is_checked'] not: 1 - type: Checkbox label: Skip Required Constraint name: some_checkbox value: it_is_checked *** Constraint.pm.orig Fri Apr 24 19:13:49 2009 --- Constraint.pm Fri Apr 24 19:18:24 2009 *************** *** 140,146 **** # nothing to constrain if field doesn't exist my $when_field_value = $self->get_nested_hash_value( $params, $when_field ); ! return 0 if !defined $when_field_value; my @values; --- 140,146 ---- # nothing to constrain if field doesn't exist my $when_field_value = $self->get_nested_hash_value( $params, $when_field ); ! return $when->{not} ? 1 : 0 if !defined $when_field_value; my @values;

Sun Mar 29 22:03:16 2015 dean [...] fragfest.com.au - Correspondence added

This patch will no longer apply. 6 years later, i suspect you arent fussed? On Fri Apr 24 19:24:18 2009, rtaylor wrote: Show quoted text

> "when" for a checkbox field does not honour "not" when the checkbox has > not been clicked. > > When the checkbox value is not clicked (!defined) then the constraint is > still skipped despite the "not" inversion. Simple one line patch below > to correct this issue. > > - type: Text > name: fieldname > constraints: > - type: Required > when: > field: some_checkbox > values: ['it_is_checked'] > not: 1 > > - type: Checkbox > label: Skip Required Constraint > name: some_checkbox > value: it_is_checked > > > > > > > *** Constraint.pm.orig Fri Apr 24 19:13:49 2009 > --- Constraint.pm Fri Apr 24 19:18:24 2009 > *************** > *** 140,146 **** > > # nothing to constrain if field doesn't exist > my $when_field_value = $self->get_nested_hash_value( $params, > $when_field ); > ! return 0 if !defined $when_field_value; > > my @values; > > --- 140,146 ---- > > # nothing to constrain if field doesn't exist > my $when_field_value = $self->get_nested_hash_value( $params, > $when_field ); > ! return $when->{not} ? 1 : 0 if !defined $when_field_value; > > my @values; >

Sun Mar 29 22:03:17 2015 The RT System itself - Status changed from 'new' to 'open'