Bug #45197 for File-FDpasser: Breakage on Linux 64 bit -- fix included

Tue Apr 21 19:33:18 2009 sam [...] email-scan.com - Ticket created

Subject:

Breakage on Linux 64 bit -- fix included

The module is definitely broken on Linux 64 bit. The attached patch fixes it.

Subject:

bsd44.patch.txt

--- bsd44.c.orig 1999-07-28 22:13:18.000000000 -0400 +++ bsd44.c 2009-04-21 19:31:36.000000000 -0400 @@ -16,7 +16,7 @@ static struct cmsghdr *cmptr = NULL; /* buffer is malloc'ed first time */ -#define CONTROLLEN (sizeof(struct cmsghdr) + sizeof(int)) +#define CONTROLLEN (CMSG_SPACE(sizeof(int))) /* size of control buffer to send/recv one file descriptor */

Wed Apr 22 20:00:45 2009 sam [...] email-scan.com - Correspondence added

An strace found a problem with my original patch. Here's the proper fix.

--- bsd44.c.orig 1999-07-28 22:13:18.000000000 -0400 +++ bsd44.c 2009-04-22 19:57:40.000000000 -0400 @@ -16,7 +16,7 @@ static struct cmsghdr *cmptr = NULL; /* buffer is malloc'ed first time */ -#define CONTROLLEN (sizeof(struct cmsghdr) + sizeof(int)) +#define CONTROLLEN (CMSG_SPACE(sizeof(int))) /* size of control buffer to send/recv one file descriptor */ @@ -44,7 +44,7 @@ if (cmptr == NULL && (cmptr = malloc(CONTROLLEN)) == NULL) return(-1); cmptr->cmsg_level = SOL_SOCKET; cmptr->cmsg_type = SCM_RIGHTS; - cmptr->cmsg_len = CONTROLLEN; + cmptr->cmsg_len = sizeof(struct cmsghdr) + sizeof(int); msg.msg_control = (caddr_t) cmptr; msg.msg_controllen = CONTROLLEN; *(int *)CMSG_DATA(cmptr) = fd; /* the fd to pass */

Wed Apr 22 20:00:48 2009 sam [...] email-scan.com - Status changed from 'new' to 'open'

Fri Nov 05 11:14:57 2010 seakoudr [...] guerrillamailblock.com - Correspondence added

From:

seakoudr [...] guerrillamailblock.com

thanks for this, helped me out a lot. Hopefully it gets added into distrib at some point.

Wed Nov 23 04:23:32 2016 bohica [...] ntlworld.com - Correspondence added

On Wed Apr 22 20:00:45 2009, MRSAM wrote: Show quoted text

> An strace found a problem with my original patch. Here's the proper fix.

Thanks from me also. Martin -- Martin J. Evans Wetherby, UK