Bug #4515 for Algorithm-Diff: Error conditions not documented

Fri Nov 28 07:43:24 2003 Guest - Ticket created

Subject:

Error conditions not documented

Algorithm::Diff is great, but doesn't explain what, for example, the diff function finds NO changes in the two sequences, or some form of error occurs. I'm about to go digging through the source, but it would be nice if they could be noted in the POD. Thanks

Fri Nov 28 07:48:34 2003 Guest - Correspondence added

Having looked through the source, it appears that Algorithm::Diff doesn't do ANY error checking and if ( say ), something that isn't an array ref is passed to it, you just get an error somewhere deep in the Algorithm::Diff code...?

Thu Feb 26 10:17:35 2004 nedkonz [...] cpan.org - Correspondence added

[guest - Fri Nov 28 07:48:34 2003]: Show quoted text

> Having looked through the source, it appears that Algorithm::Diff > doesn't do ANY error checking and if ( say ), something that isn't an > array ref is passed to it, you just get an error somewhere deep in the > Algorithm::Diff code...? >

Hmm... I guess you're right. I added a check for non-refs to the code. Thanks, Ned

Thu Feb 26 10:19:39 2004 nedkonz [...] cpan.org - Correspondence added

[guest - Fri Nov 28 07:43:24 2003]: Show quoted text

> Algorithm::Diff is great, but doesn't explain what, for example, the > diff function finds NO changes in the two sequences,

The docs say that it returns a list of the edits. If there are no changes, that list is empty. I clarified that in the docs, though, as well as adding notes for the other functions (traverse_sequences, etc.) that note that they don't have useful return values. Show quoted text

> or some form of > error occurs.

It dies a horrible and obscure death, as you noted. Thanks, Ned

Thu Feb 26 10:45:14 2004 nedkonz [...] cpan.org - Status changed from 'new' to 'resolved'

Thu Feb 26 10:45:45 2004 nedkonz [...] cpan.org - Status changed from 'resolved' to 'open'

Thu Feb 26 10:46:16 2004 nedkonz [...] cpan.org - Taken