Bug #45136 for Parse-Marpa: Marpa.pm tries to call die_with_parse

Sun Apr 19 00:54:45 2009 pcwalton [...] cs.ucla.edu - Ticket created

Subject:

Marpa.pm tries to call die_with_parse_failure

When parsing fails, Marpa.pm tries to call die_with_parse_failure from the Parse::Marpa::Internal package. But that function is located in Parse::Marpa::Internal::Grammar (in Grammar.pm). So it fails: Undefined subroutine &Parse::Marpa::Internal::die_with_parse_failure called at /usr/share/perl5/vendor_perl/Parse/Marpa.pm line 159. A workaround is: *Parse::Marpa::Internal::die_with_parse_failure = *Parse::Marpa::Internal::Grammar::die_with_parse_failure{CODE};

Sun Apr 19 13:06:41 2009 jkegl [...] cpan.org - Taken

Sun Apr 19 13:10:01 2009 jkegl [...] cpan.org - Correspondence added

On Sun Apr 19 00:54:45 2009, pcwalton wrote: Show quoted text

> When parsing fails, Marpa.pm tries to call die_with_parse_failure from > the Parse::Marpa::Internal package. But that function is located in > Parse::Marpa::Internal::Grammar (in Grammar.pm). So it fails: > > Undefined subroutine &Parse::Marpa::Internal::die_with_parse_failure > called at /usr/share/perl5/vendor_perl/Parse/Marpa.pm line 159. > > A workaround is: > *Parse::Marpa::Internal::die_with_parse_failure = > *Parse::Marpa::Internal::Grammar::die_with_parse_failure{CODE};

Thanks. Since freezing Parse::Marpa I've switched to using perlcritic's Modules::RequireExplicitInclusion to prevent this kind of bug. That's what I believe I'll do here.

Sun Apr 19 13:10:07 2009 The RT System itself - Status changed from 'new' to 'open'

Sun Apr 19 21:56:22 2009 jkegl [...] cpan.org - Correspondence added

I've made the fix by resolving all subroutine references to the satisfaction of perlcritic's Modules::RequireExplicitInclusion policy. In the process I made the code perlcritic and perltidy clean. The fix is in developer's version 1.003_000. If you can try it out, I'd appreciate it. I wait a few days for you and cpantester's feedback, then roll out an official release if all looks good.

Mon Apr 20 00:12:15 2009 jkegl [...] cpan.org - Correspondence added

Correction: the policy I'm using is actually Subroutines::ProhibitCallsToUndeclaredSubs in Perl::Critic::StricterSubs. But, anyway, the problem is fixed in developer's version 1.003_000, released earlier today.

Wed Apr 29 13:26:05 2009 jkegl [...] cpan.org - Fixed in 1.003_000 added

Wed Apr 29 13:27:19 2009 jkegl [...] cpan.org - Correspondence added

Just put an official release with this fix on CPAN: 1.004000.

Wed Apr 29 13:27:20 2009 jkegl [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #45136 for Parse-Marpa: Marpa.pm tries to call die_with_parse_failure