Bug #45111 for Module-Build: Module::Build::Compat's 'traditional' form tries to use Module::Build.

Fri Apr 17 13:59:22 2009 DStaal [...] usa.net - Ticket created

Subject:

Module::Build::Compat's 'traditional' form tries to use Module::Build.

Module::Build::Compat's 'traditional' makefile fails to exclude Build.PL (if it is present) from the build process, requiring it to either be deleted from the archive or have someone manually edit the makefile to exclude it. This makes it somewhat difficult to bundle modules with both Build.PL and Makefile.PL, as the latter has to be edited manually after being auto-generated.

Fri Apr 17 14:12:24 2009 enobacon [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #45111] Module::Build::Compat's 'traditional' form tries to use Module::Build.
Date:	Fri, 17 Apr 2009 11:12:01 -0700
To:	bug-Module-Build [...] rt.cpan.org
From:	Eric Wilhelm <enobacon [...] gmail.com>

Hi Daniel, # from Daniel T. Staal via RT on Friday 17 April 2009 10:59: Show quoted text

>Module::Build::Compat's 'traditional' makefile fails to exclude > Build.PL (if it is present) from the build process

Sorry, I can't reproduce that with 0.32. Can you provide an example Build.PL (or tarball) which illustrates the bug? Thanks, Eric

Fri Apr 17 14:12:25 2009 The RT System itself - Status changed from 'new' to 'open'

Fri Apr 17 14:57:50 2009 kwilliams [...] cpan.org - Correspondence added

Eric, might this have to do with the following commit? ------------------------------------------------------------------------ r12568 | dagolden | 2009-03-03 22:25:42 -0600 (Tue, 03 Mar 2009) | 6 lines Module::Build::Compat had stopped adding PL_FILES=>{} if PL_files wasn't set in Build.PL; restored old behavior. Also fixed buggy tests that weren't detecting this bug and changed ancient documentation suggesting setting PL_FILES manually as that is irrelevant now that this works again.

Fri Apr 17 15:48:12 2009 DStaal [...] usa.net - Correspondence added

Subject:	Re: [rt.cpan.org #45111] Module::Build::Compat's 'traditional' form tries to use Module::Build.
Date:	Fri, 17 Apr 2009 15:47:52 -0400 (EDT)
To:	bug-Module-Build [...] rt.cpan.org
From:	"Daniel Staal" <DStaal [...] usa.net>

On Fri, April 17, 2009 2:12 pm, Eric Wilhelm via RT wrote: Show quoted text

> <URL: http://rt.cpan.org/Ticket/Display.html?id=45111 > > > Hi Daniel, > > # from Daniel T. Staal via RT on Friday 17 April 2009 10:59:

>>Module::Build::Compat's 'traditional' makefile fails to exclude >> Build.PL (if it is present) from the build process

> > Sorry, I can't reproduce that with 0.32. Can you provide an example > Build.PL (or tarball) which illustrates the bug?

Sure, attached. (From a recent package I pushed around the office to notice this.) I should note that I ran the attached tarball under Perl 5.8.5, which has ExtUtils::MakeMaker 6.17 (I assume...). It's possible that the ancient platform makes a difference. (I didn't bother to run the test suite, so I didn't have to upgrade anything.) The tarball was _built_ using 5.10, and Module::Build 0.32. Daniel T. Staal

Download DSES-1.0.tar.gz
application/x-gzip 10k

Message body not shown because it is not plain text.

Fri Apr 17 23:58:31 2009 dagolden [...] cpan.org - Correspondence added

It's a bug that was fixed in 0.32_01. Regards, David

Fri Apr 17 23:58:32 2009 dagolden [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Apr 18 12:53:50 2009 EWILHELM [...] cpan.org - Correspondence added

Subject:

Module::Build::Compat's 'traditional' form -- older ExtUtils::MakeMaker runs Build.PL

On Fri Apr 17 15:48:12 2009, DSTAAL wrote: Show quoted text

> I should note that I ran the attached tarball under Perl 5.8.5, > which has ExtUtils::MakeMaker 6.17 (I assume...). It's possible > that the ancient platform makes a difference.

Indeed. This is why I couldn't replicate it on M::B 0.32 here. The newer ExtUtils::MakeMaker specifically ignores Build.PL, but we needed to have the PL_FILES=>{} to avoid tripping up older EU::MM. As Ken and David noted, this is fixed in svn r12568 and we're currently vetting 0.32_01 toward the official 0.33 release. Thanks, Eric

Sat Apr 18 12:53:51 2009 The RT System itself - Status changed from 'resolved' to 'open'

Sat Apr 18 12:54:32 2009 EWILHELM [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Apr 18 12:54:32 2009 EWILHELM [...] cpan.org - Fixed in 0.32_01 added