Bug #45036 for Test-Aggregate: Test-Simple 0.8701 breaks Test-Aggregate-0.35

Tue Apr 14 15:34:48 2009 ANDK [...] cpan.org - Ticket created

CC:	ovid [...] cpan.org
Subject:	Test-Simple 0.8701 breaks Test-Aggregate-0.35

0.87_02 made it even worse but RT doesn't let me click on it. I'm sure one of you two knows what's going on, right? I'm now downgrading all my smokers to Test-Simple 0.84 again. Let me know if you need more data.

Tue Apr 14 16:05:14 2009 schwern [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #45036] Test-Simple 0.8701 breaks Test-Aggregate-0.35
Date:	Tue, 14 Apr 2009 13:04:49 -0700
To:	bug-Test-Simple [...] rt.cpan.org
From:	Michael G Schwern <schwern [...] pobox.com>

Andreas Koenig via RT wrote: Show quoted text

> 0.87_02 made it even worse but RT doesn't let me click on it. > > I'm sure one of you two knows what's going on, right? > > I'm now downgrading all my smokers to Test-Simple 0.84 again. > > Let me know if you need more data.

Yes, I would like some data. Let's start with an error message of some sort. -- The past has a vote, but not a veto. -- Mordecai M. Kaplan

Tue Apr 14 16:05:15 2009 The RT System itself - Status changed from 'new' to 'open'

Tue Apr 14 22:39:35 2009 andreas.koenig.7os6VVqR [...] franz.ak.mind.de - Correspondence added

CC:	ANDK [...] cpan.org, ovid [...] cpan.org
Subject:	Re: [rt.cpan.org #45036] Test-Simple 0.8701 breaks Test-Aggregate-0.35
Date:	Wed, 15 Apr 2009 04:38:41 +0200
To:	bug-Test-Simple [...] rt.cpan.org
From:	andreas.koenig.7os6VVqR [...] franz.ak.mind.de (Andreas J. Koenig)

Show quoted text

>>>>> On Tue, 14 Apr 2009 16:05:22 -0400, "Michael G Schwern via RT" <bug-Test-Simple@rt.cpan.org> said:

I just ran the Test::Aggregate tests. Downgrading to Test::Simple 0.84 makes the tests OK, upgrading to 0.87_02 produces these errors. There's only that much I can tell from the failing tests. Running Build test t/aggregate.......# ok - aggtests/skip_all.t (1 out of 7) # Testing Test::Aggregate 0.35, Perl 5.010000, /usr/local/perl-5.10-g/bin/perl # ok - aggtests/00-load.t (2 out of 7) # ok - aggtests/check_plan.t (3 out of 7) # ok - aggtests/boilerplate.t (4 out of 7) # ok - aggtests/findbin.t (5 out of 7) # ok - aggtests/subs.t (6 out of 7) # ok - aggtests/slow_load.t (7 out of 7) # Looks like you planned 2 tests but ran 23. Dubious, test returned 255 (wstat 65280, 0xff00) All 23 subtests passed (less 2 skipped subtests: 21 okay) t/pod-coverage....ok t/pod.............ok t/pre_post........# Testing Test::Aggregate 0.35, Perl 5.010000, /usr/local/perl-5.10-g/bin/perl # ok - aggtests/00-load.t (1 out of 7) # ok - aggtests/boilerplate.t (2 out of 7) # ok - aggtests/check_plan.t (3 out of 7) # ok - aggtests/findbin.t (4 out of 7) # ok - aggtests/skip_all.t (5 out of 7) # ok - aggtests/slow_load.t (6 out of 7) # ok - aggtests/subs.t (7 out of 7) Cannot unlink (dump.t): No such file or directory at t/pre_post.t line 39. # Looks like you planned 1 test but ran 20. Dubious, test returned 255 (wstat 65280, 0xff00) All 20 subtests passed (less 2 skipped subtests: 18 okay) t/subs............# ok - aggtests/subs.t (1 out of 1) # Looks like you planned 1 test but ran 2. Dubious, test returned 255 (wstat 65280, 0xff00) All 2 subtests passed Test Summary Report ------------------- t/aggregate (Wstat: 65280 Tests: 23 Failed: 0) Non-zero exit status: 255 t/pre_post (Wstat: 65280 Tests: 20 Failed: 0) Non-zero exit status: 255 t/subs (Wstat: 65280 Tests: 2 Failed: 0) Non-zero exit status: 255 Files=5, Tests=48, 3 wallclock secs ( 0.03 usr 0.02 sys + 0.30 cusr 0.04 csys = 0.39 CPU) Result: FAIL Failed 3/5 test programs. 0/48 subtests failed. (./Build test exited with 65280) -- andreas

Wed Apr 15 05:39:03 2009 curtis_ovid_poe [...] yahoo.com - Correspondence added

CC:	ANDK [...] cpan.org, ovid [...] cpan.org
Subject:	Re: [rt.cpan.org #45036] Test-Simple 0.8701 breaks Test-Aggregate-0.35
Date:	Wed, 15 Apr 2009 02:38:48 -0700 (PDT)
To:	"Andreas J. Koenig" <andreas.koenig.7os6VVqR [...] franz.ak.mind.de>, bug-Test-Simple [...] rt.cpan.org
From:	Ovid <curtis_ovid_poe [...] yahoo.com>

Show quoted text

----- Original Message ----

> From: Andreas J. Koenig <andreas.koenig.7os6VVqR@franz.ak.mind.de> >

> >>>>> On Tue, 14 Apr 2009 16:05:22 -0400, "Michael G Schwern via RT"

> said: > > I just ran the Test::Aggregate tests. Downgrading to Test::Simple 0.84 > makes the tests OK, upgrading to 0.87_02 produces these errors. > There's only that much I can tell from the failing tests.

I'm reasonably certain that I know what this issue is and I'll hold up my hand as a mea culpa. Basically, Test::Aggregate needed to do a lot of work altering how Test::Builder handles plans. Because Test::Builder offered no interface for this, I hacked the Test::Builder internals and added a big fat warning as the first line of the description. I wasn't *too* worried about this because the bit of code I was touching hadn't been altered in years, but I knew it would break. As it stands, since Schwern has now altered the internals to offer more flexibility with plans, Test::Aggregate broke, but it's my fault for reaching into the internals (the only alternative is to ship my own Test::Builder, something I've been dangerously close to doing :). I knew at the hackathon that these changes were coming, but I had not expected someone using a devel version of Test::Simple to also be using Test::Aggregate. My bad :( In any event, I do have some code to deal with this, but it's incomplete. I'll dig it out and see if I can get a new release of Test::Aggregate out there. Hopefully one which minimizes the internals munging of Test::Builder. Cheers, Ovid -- Buy the book - http://www.oreilly.com/catalog/perlhks/ Tech blog - http://use.perl.org/~Ovid/journal/ Twitter - http://twitter.com/OvidPerl Official Perl 6 Wiki - http://www.perlfoundation.org/perl6

Wed Apr 15 09:41:13 2009 curtis_ovid_poe [...] yahoo.com - Correspondence added

CC:	ovid [...] cpan.org
Subject:	Re: [rt.cpan.org #45036] Test-Simple 0.8701 breaks Test-Aggregate-0.35
Date:	Wed, 15 Apr 2009 06:40:55 -0700 (PDT)
To:	bug-Test-Simple [...] rt.cpan.org, ANDK [...] cpan.org
From:	Ovid <curtis_ovid_poe [...] yahoo.com>

I forgot to mention that most (not all) of the mucking about in Test::Builder internals will go away once nested TAP is merged. Cheers, Ovid -- Buy the book - http://www.oreilly.com/catalog/perlhks/ Tech blog - http://use.perl.org/~Ovid/journal/ Twitter - http://twitter.com/OvidPerl Official Perl 6 Wiki - http://www.perlfoundation.org/perl6

Wed Apr 15 11:55:21 2009 mschwern [...] cpan.org - Queue changed from Test-Simple to Test-Aggregate

Wed Apr 15 15:29:01 2009 andreas.koenig.7os6VVqR [...] franz.ak.mind.de - Correspondence added

CC:	ANDK [...] cpan.org, ovid [...] cpan.org
Subject:	Re: [rt.cpan.org #45036] Test-Simple 0.8701 breaks Test-Aggregate-0.35
Date:	Wed, 15 Apr 2009 21:28:31 +0200
To:	bug-Test-Simple [...] rt.cpan.org
From:	andreas.koenig.7os6VVqR [...] franz.ak.mind.de (Andreas J. Koenig)

Show quoted text

> I knew at the hackathon that these changes were coming, but I had > not expected someone using a devel version of Test::Simple to also > be using Test::Aggregate. My bad :(

Don't worry, it's just a smoker, no real harm done. My smokers pick up dev versions to catch breakage like this earlier than they reach a wider audience.

Thu May 14 17:37:50 2009 ovid [...] cpan.org - Correspondence added

This should be fixed in the latest (0.35_03) release. Thanks for the report. Cheers, Ovid

Thu May 14 17:37:52 2009 ovid [...] cpan.org - Status changed from 'open' to 'resolved'