| Subject: | Bug report: Advent calculations are off |
| Date: | Fri, 10 Apr 2009 16:42:57 -0700 |
| To: | bug-DateTime-Calendar-Liturgical-Christian [...] rt.cpan.org |
| From: | Malcolm Heath <malcolm [...] indeterminate.net> |
Hi there,
I'm very interested in using DateTime::Calendar::Liturgical::Christian,
since I manage the website for an ECUSA church.
However, in testing with it, I noticed that the First Sunday in Advent
calculation seems to be off.
For example, in 2008, Advent I is November 30th, but the module shows
this as one week earlier.
Likewise, for 2009, Advent I is November 29th, and the module shows it
as a week earlier.
I started to dig into the code to see how you were figuring this. But
then it occurred to me to suggest that you merely find the Sunday
closest to November 30 (The Feast of St. Andrew), either before or
after. An alternate method is to find the Sunday following the last
Thursday in November.
It seems to me that the first method might be easier. If November 30th
is a Sunday, then that's First Advent and St. Andrew gets moved.
I want to thank you very much for all the work. As far as I've been
able to tell so far, everything else seems to work splendidly.
Malcolm Heath