Bug #44884 for DBD-SQLite: Avoid use of DBIS macro in driver internals

Wed Apr 08 18:15:19 2009 TIMB [...] cpan.org - Ticket created

Subject:

Avoid use of DBIS macro in driver internals

Avoid use of DBIS macro in driver internals because it's very slow on perls configured with threading enabled (which is the case on most linux distributions). http://search.cpan.org/grep?cpanid=ADAMK&release=DBD-SQLite-1.22_02&string=DBIS- %3E&F=1&n=1&C=0 Replace with DBIc_DBISTATE(imp_xxh) in the general case. For DBIS->debug you should use DBIc_TRACE(imp_xxh, flags, flaglevel, level). See DBIXS.h for details. To make those changes you may need to pass the imp_xxh struct pointer into functions. (Passing both SV *h, the handle, and imp_xxh is recommended). While you're doing that, you should also aim to eliminate use of dTHR. That's also expensive and occurs frequently in the code: http://search.cpan.org/grep?cpanid=ADAMK&release=DBD-SQLite- 1.22_02&string=dTHR&F=1&n=1&C=0 Fix that by adding pTHX_ as the first param (with no trailing comma) of the function that calls dTHR, and adding aTHX_ as the first argument in all the calls.

Wed Apr 08 20:23:13 2009 adamk [...] cpan.org - Correspondence added

On Wed Apr 08 18:15:19 2009, TIMB wrote: Show quoted text

> Avoid use of DBIS macro in driver internals because it's very slow on > perls configured with > threading enabled (which is the case on most linux distributions). > > http://search.cpan.org/grep?cpanid=ADAMK&release=DBD-SQLite- > 1.22_02&string=DBIS- > %3E&F=1&n=1&C=0 > > Replace with DBIc_DBISTATE(imp_xxh) in the general case.

The only non-debug DBIS usage is in the init function, where there is no imp_xxh. void sqlite_init(dbistate_t *dbistate) { dTHR; DBIS = dbistate; } How should this be converted? Show quoted text

> For DBIS->debug you should use DBIc_TRACE(imp_xxh, flags, flaglevel, > level). See DBIXS.h > for details. > > To make those changes you may need to pass the imp_xxh struct pointer > into functions. > (Passing both SV *h, the handle, and imp_xxh is recommended). > > While you're doing that, you should also aim to eliminate use of dTHR. > That's also expensive > and occurs frequently in the code: > > http://search.cpan.org/grep?cpanid=ADAMK&release=DBD-SQLite- > 1.22_02&string=dTHR&F=1&n=1&C=0 > > Fix that by adding pTHX_ as the first param (with no trailing comma) > of the function that > calls dTHR, and adding aTHX_ as the first argument in all the calls. >

Can you provide an example conversion of one of the uses? Adam K

Wed Apr 08 20:23:14 2009 The RT System itself - Status changed from 'new' to 'open'

Thu Apr 09 08:50:00 2009 Tim.Bunce [...] pobox.com - Correspondence added

CC:	TIMB [...] cpan.org
Subject:	Re: [rt.cpan.org #44884] Avoid use of DBIS macro in driver internals
Date:	Thu, 9 Apr 2009 13:49:41 +0100
To:	Adam Kennedy via RT <bug-DBD-SQLite [...] rt.cpan.org>
From:	Tim Bunce <Tim.Bunce [...] pobox.com>

On Wed, Apr 08, 2009 at 08:23:14PM -0400, Adam Kennedy via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=44884 > > > The only non-debug DBIS usage is in the init function, where there is no > imp_xxh. > > void > sqlite_init(dbistate_t *dbistate) > { > dTHR; > DBIS = dbistate; > } > > How should this be converted?

If DBIS is no longer used it can be deleted. That's good. Show quoted text

> > Fix that by adding pTHX_ as the first param (with no trailing comma) > > of the function that > > calls dTHR, and adding aTHX_ as the first argument in all the calls.

> > Can you provide an example conversion of one of the uses?

See DBI source code for lots of examples of their use. Ask on dbi-dev@perl perl5-porters@perl.org for more help. Tim.

Sat Apr 11 00:58:45 2009 ishigaki [...] cpan.org - Correspondence added

I think this is (almost) fixed in 1.22_04 (except for the ones related to the func, for which we're waiting for a new DBI). On Thu, Apr 09 08:50:00 2009, Tim.Bunce@pobox.com wrote: Show quoted text

> On Wed, Apr 08, 2009 at 08:23:14PM -0400, Adam Kennedy via RT wrote:

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=44884 > > > > > The only non-debug DBIS usage is in the init function, where there

is no Show quoted text

> > imp_xxh. > > > > void > > sqlite_init(dbistate_t *dbistate) > > { > > dTHR; > > DBIS = dbistate; > > } > > > > How should this be converted?

> > If DBIS is no longer used it can be deleted. That's good. >

> > > Fix that by adding pTHX_ as the first param (with no trailing

comma) Show quoted text

> > > of the function that > > > calls dTHR, and adding aTHX_ as the first argument in all the

calls. Show quoted text

> > > > Can you provide an example conversion of one of the uses?

> > See DBI source code for lots of examples of their use. Ask on > dbi-dev@perl perl5-porters@perl.org for more help. > > Tim.

Wed Apr 15 20:50:08 2009 adamk [...] cpan.org - Correspondence added

Resolved

Wed Apr 15 20:50:11 2009 adamk [...] cpan.org - Status changed from 'open' to 'resolved'