| Subject: | Column comments are misrendered |
Comments on columns generate invalid HTML and end up outside the table
(in Firefox, at least). Attached is a patch fixing the issue.
| Subject: | comment.diff |
commit d833a3568428f41885d0a9a28530e0b987a30eda
Author: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Date: 2009-04-07 13:56:11 +0100
Fix comment rendering
diff --git a/templates/columns_row.tt2 b/templates/columns_row.tt2
index b96ca79..2b0df9a 100644
--- a/templates/columns_row.tt2
+++ b/templates/columns_row.tt2
@@ -4,6 +4,7 @@
<td>[% INCLUDE column_name.tt2 %]</td>
<td>[% INCLUDE column_type.tt2 %]</td>
<td>[% INCLUDE column_info.tt2 %]</td>
+ </tr>
[% INCLUDE table_comment.tt2 colspan = 2 comment = col.comment %]
[% END -%]
[%# $Id$ #%]
diff --git a/templates/table_comment.tt2 b/templates/table_comment.tt2
index 64e023e..212ad32 100644
--- a/templates/table_comment.tt2
+++ b/templates/table_comment.tt2
@@ -1,7 +1,7 @@
[% IF comment %]
<tr class="[% class %]">
<td> </td>
- <td[% IF colspan %]colspan="[% colspan %]"[% END %]>
+ <td[% IF colspan %] colspan="[% colspan %]"[% END %]>
<div class="comment">[% comment %]</div>
</td>
</tr>