Skip Menu |

This queue is for tickets about the SQL-Abstract CPAN distribution.

Report information
The Basics
Id: 44669
Status: resolved
Priority: 0/
Queue: SQL-Abstract
People
Owner: Nobody in particular
Requestors: SMPETERS [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: (no value)
Fixed in: 1.52

History Show all quoted text
  Mon Mar 30 09:25:50 2009 SMPETERS [...] cpan.org - Ticket created
Subject: [PATCH] Silence undefined warnings in bleadperl
Bleadperl now warns when undef is passed to uc(). While this isn't really a big deal in code execution, it does cause test failures for SQL::Abstract. The patch below silences the warnings and gets the tests to pass again. Steve Peters --- lib/SQL/Abstract.pm 2009-03-28 08:35:13.000000000 -0500 +++ lib/SQL/Abstract.pm.new 2009-03-30 08:17:27.000000000 -0500 @@ -63,7 +63,7 @@ delete $opt{case} if $opt{case} && $opt{case} ne 'lower'; # default logic for interpreting arrayrefs - $opt{logic} = uc $opt{logic} || 'OR'; + $opt{logic} = $opt{logic} ? uc $opt{logic} : 'OR'; # how to return bind vars # LDNOTE: changed nwiger code : why this 'delete' ??
  Tue Apr 21 02:31:16 2009 ribasushi [...] leporine.io - Correspondence added
On Mon Mar 30 09:25:50 2009, SMPETERS wrote: Show quoted text
> Bleadperl now warns when undef is passed to uc(). While this isn't > really a big deal in code > execution, it does cause test failures for SQL::Abstract. The patch > below silences the > warnings and gets the tests to pass again. > > Steve Peters > > > --- lib/SQL/Abstract.pm 2009-03-28 08:35:13.000000000 -0500 > +++ lib/SQL/Abstract.pm.new 2009-03-30 08:17:27.000000000 -0500 > @@ -63,7 +63,7 @@ > delete $opt{case} if $opt{case} && $opt{case} ne 'lower'; > > # default logic for interpreting arrayrefs > - $opt{logic} = uc $opt{logic} || 'OR'; > + $opt{logic} = $opt{logic} ? uc $opt{logic} : 'OR'; > > # how to return bind vars > # LDNOTE: changed nwiger code : why this 'delete' ??
Committed to svn as r5921. Thanks.
  Tue Apr 21 02:31:17 2009 The RT System itself - Status changed from 'new' to 'open'
  Wed Apr 29 03:28:35 2009 ribasushi [...] leporine.io - Fixed in 1.52 added
  Sat May 02 18:59:58 2009 ribasushi [...] leporine.io - Status changed from 'open' to 'resolved'