Bug #44637 for Params-Validate: micro optimization for Params::Validate

On Sat, 28 Mar 2009, Tokuhiro Matsuno via RT wrote: Show quoted text
Why are you using the pure Perl version? The XS version is (last I checked) about twice as fast as the pure Perl version. -dave /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/

On Sat, Mar 28, 2009 at 11:21 PM, autarch@urth.org via RT <bug-Params-Validate@rt.cpan.org> wrote: Show quoted text
XS version is not a fast in my environment. benchmark score is here: -- 0.91 pp ver 5.010000 pp ver Benchmark: timing 100000 iterations of complex, simple... complex: 9 wallclock secs ( 8.58 usr + 0.00 sys = 8.58 CPU) @ 11655.01/s (n=100000) simple: 5 wallclock secs ( 5.19 usr + 0.00 sys = 5.19 CPU) @ 19267.82/s (n=100000) -- 0.91 xs ver 5.010000 xs ver Benchmark: timing 100000 iterations of complex, simple... complex: 8 wallclock secs ( 7.47 usr + 0.00 sys = 7.47 CPU) @ 13386.88/s (n=100000) simple: 5 wallclock secs ( 5.28 usr + 0.00 sys = 5.28 CPU) @ 18939.39/s (n=100000) -- 0.91 pp ver + my patch 5.010000 pp ver Benchmark: timing 100000 iterations of complex, simple... complex: 8 wallclock secs ( 7.60 usr + 0.00 sys = 7.60 CPU) @ 13157.89/s (n=100000) simple: 4 wallclock secs ( 4.15 usr + 0.00 sys = 4.15 CPU) @ 24096.39/s (n=100000) looks like a pp ver + my patch is faster than xs version.why?? how to get a 2x score? followings are benchmarks script. use strict; use warnings; use Params::Validate; use Benchmark ':all'; use UNIVERSAL::which; print "$]\n"; print $INC{'Params/ValidateXS.pm'} ? "xs ver\n" : "pp ver\n"; timethese( 100000 => { simple => sub { simple(a => 1, b => 1) }, complex => sub { complex(a => bless({}, 'Foo'), b => bless([], 'main')) }, }, ); sub simple { my %args = validate( @_, { a => 1, b => 1, }, ); 1; } sub complex { my %args = validate( @_, { a => { isa => 'Foo', }, b => { can => 'complex', }, }, ); 1; }