Bug #44584 for Perl-Dist-Strawberry: PPM.pm:InstallPackage() bug triggered if $ENV{HOME} valid

Wed Mar 25 20:03:57 2009 krishpl [...] shamu.corp.sgi.com - Ticket created

Subject:

PPM.pm:InstallPackage() bug triggered if $ENV{HOME} valid

Strawberry perl portable 5.10 (release compiled at Feb 23 2009) PPM.pm's InstallPackage() downloads and unpacks a package, and then looks like it tries to chdir(undef) and falls back to chdir($ENV {HOME}). If $ENV{HOME} is set, the rest of the install fails; if not, the chdir fails and installation proceeds as normal. See http:// www.perlfoundation.org/perl5/index.cgi?ppm , under 'Gotchas'. Reproduce: in cmd.exe, set HOME=<some valid value>, then cd to <strawberry-perl-portable-top>\perl\bin, and run .\ppm.bat install <package> Workaround: set HOME= before running ppm.bat.

Wed Sep 09 14:00:44 2009 csjewell [...] cpan.org - Correspondence added

On Wed Mar 25 20:03:57 2009, KRISHPL wrote: Show quoted text

> Strawberry perl portable 5.10 (release compiled at Feb 23 2009) > PPM.pm's InstallPackage() downloads and unpacks a package, and then > looks like it tries to chdir(undef) and falls back to chdir($ENV > {HOME}). If $ENV{HOME} is set, the rest of the install fails; if not, > the chdir fails and installation proceeds as normal. See http:// > www.perlfoundation.org/perl5/index.cgi?ppm , under 'Gotchas'. > > Reproduce: in cmd.exe, set HOME=<some valid value>, then cd to > <strawberry-perl-portable-top>\perl\bin, and run .\ppm.bat install > <package> > Workaround: set HOME= before running ppm.bat.

IMO: This should use $ENV{HOME} // $ENV{USERPROFILE}. I may fix this for October 2009... stay tuned.

Wed Sep 09 14:00:46 2009 The RT System itself - Status changed from 'new' to 'open'

Wed Sep 09 14:01:28 2009 csjewell [...] cpan.org - Given to CSJEWELL

Wed Sep 09 14:01:29 2009 csjewell [...] cpan.org - Severity Normal changed to Important

Wed Sep 09 14:01:29 2009 csjewell [...] cpan.org - Broken in 2.00 added

Mon Oct 12 03:24:50 2009 csjewell [...] cpan.org - Dependency by ticket #50409 added

Tue Dec 15 11:18:37 2009 tsukamoto [...] gmail.com - Correspondence added

I encountered it in 5.8.9.3. At line 387 in C:\strawberry\perl\vendor\lib\PPM.pm, $1 becomes empty and chdir(undef) happens as KRISHPL writing. It seems to need to use a named variable instead of $1. Attached file is diff output of my modification.

379a380 > my $tarzip_dir; 381a383 > $tarzip_dir = $1; 385a388 > $tarzip_dir = $1; 387c390 < chdir($1); --- > chdir($tarzip_dir);

Wed Feb 17 16:27:46 2010 csjewell [...] cpan.org - Dependency by ticket #50409 deleted

Wed Feb 17 16:27:47 2010 csjewell [...] cpan.org - Dependency by ticket #54728 added

Fri Feb 19 11:44:20 2010 csjewell [...] cpan.org - Correspondence added

Pstched in r11370, will be fully fixed when the April 2009 versions arrive.

Fri Feb 19 11:44:24 2010 csjewell [...] cpan.org - Reference to http://fisheye2.atlassian.com/changelog/cpan/?cs=11370 added

Fri Feb 19 11:44:36 2010 csjewell [...] cpan.org - Status changed from 'open' to 'patched'

Sun May 02 21:44:20 2010 csjewell [...] cpan.org - Status changed from 'patched' to 'resolved'