Bug #44554 for Perl-Critic: 2-arg open that is not criticized

Wed Mar 25 08:06:50 2009 CHORNY [...] cpan.org - Ticket created

Subject:

2-arg open that is not criticized

I was writing 3-arg open check for Perl::MinimumVersion and decided to check one of test examples in perlcritic. For this program: use strict; open my $a,'testing' or die "error: ",$!; open (my $a,'testing') or die "error: ",$!; perlcritic complains only about second open. -- Alexandr Ciornii, http://chorny.net

Sat Mar 28 23:21:34 2009 wyant [...] cpan.org - Correspondence added

On Wed Mar 25 08:06:50 2009, CHORNY wrote: Show quoted text

> I was writing 3-arg open check for Perl::MinimumVersion and decided to > check one of test examples in perlcritic. > > For this program: > use strict; > open my $a,'testing' or die "error: ",$!; > open (my $a,'testing') or die "error: ",$!; > > perlcritic complains only about second open. >

Proposed fix committed as SVN revision 3249. The problem appears to be that P::C::Utils function parse_arg_list() was not terminating the parse on encountering one of the low-precedence booleans. Tom Wyant

Sat Mar 28 23:21:35 2009 The RT System itself - Status changed from 'new' to 'open'

Sun Aug 23 06:33:56 2009 ELLIOTJS [...] cpan.org - Status changed from 'open' to 'patched'

Tue Aug 25 23:26:39 2009 perl [...] galumph.com - Correspondence added

Subject:	Re: [rt.cpan.org #44554] 2-arg open that is not criticized
Date:	Tue, 25 Aug 2009 22:26:17 -0500
To:	bug-Perl-Critic [...] rt.cpan.org
From:	Elliot Shank <perl [...] galumph.com>

The fix for this was released in v1.104.

Tue Aug 25 23:26:39 2009 The RT System itself - Status changed from 'patched' to 'open'

Tue Aug 25 23:32:43 2009 ELLIOTJS [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Aug 25 23:32:44 2009 ELLIOTJS [...] cpan.org - Fixed in 1.104 added

Bug #44554 for Perl-Critic: 2-arg open that is not criticized

Preferred bug tracker