Bug #44522 for ClearCase-Argv: ClearCase::Argv 1.44 doesn't quote anymore

Tue Mar 24 11:45:05 2009 dirk.heinrichs.ext [...] nsn.com - Ticket created

Subject:	ClearCase::Argv 1.44 doesn't quote anymore
Date:	Tue, 24 Mar 2009 16:44:40 +0100
To:	<bug-ClearCase-Argv [...] rt.cpan.org>
From:	"Heinrichs, Dirk (EXT-Capgemini - DE/Dusseldorf)" <dirk.heinrichs.ext [...] nsn.com>

Hello, after upgrade to version 1.44, ClearCase::Argv doesn't quote anymore. This leads to problems when attaching attributes, because the value needs to be quoted like this: '"value"'. This fails with version 1.44 because of the missing single quotes. Here's a small example output of a script started on a machine with version 1.44 (dbglevel set to 2): => pwv -short + <=vobroot_default + ($? == 0) => ls -s /vob/itrBuild + <=/vob/itrBuild/lost+found@@/main/0 /vob/itrBuild/lost+found@@/main/0 + ($? == 0) And this is how the same script looks like when using an older version of the module (notice the single quotes): + starting child cleartool (pid=19648) ... + -->> 'setview' 'vobroot_default' + -->> 'pwv' '-short' + <<-- vobroot_default + -->> 'ls' '-s' '/vob/itrBuild' + <<-- /vob/itrBuild/lost+found@@/main/0 /vob/itrBuild/lost+found@@/main/0 + ($? == 0) + ending child cleartool (pid=19648) ... With the old version, mkattr works just fine, while with 1.44 it doesn't. Bye... Dirk -- Dirk Heinrichs | Tel: +49 (0)162 234 3408 Configuration Manager | Fax: +49 (0)211 47068 111 Capgemini Deutschland | Mail: dirk.heinrichs@capgemini.com Wanheimerstraße 68 | Web: http://www.capgemini.com D-40468 Düsseldorf | ICQ#: 110037733 GPG Public Key C2E467BB | Keyserver: www.keyserver.net

Download (untitled)
application/pgp-signature 205b

Message body not shown because it is not plain text.

Fri Apr 24 05:18:17 2009 dirk.heinrichs.ext [...] nsn.com - Correspondence added

Subject:	Re: [rt.cpan.org #44522] ClearCase::Argv 1.44 doesn't quote anymore
Date:	Fri, 24 Apr 2009 11:17:53 +0200
To:	bug-ClearCase-Argv [...] rt.cpan.org
From:	Dirk Heinrichs <dirk.heinrichs.ext [...] nsn.com>

Hi, as an additional information it may be worth to know that the last version that doesn't have this problem is 1.24. Otherwise: Any news on the issue? Bye... Dirk -- Dirk Heinrichs | Tel: +49 (0)162 234 3408 Configuration Manager | Fax: +49 (0)211 47068 111 Capgemini Deutschland | Mail: dirk.heinrichs@capgemini.com Wanheimerstraße 68 | Web: http://www.capgemini.com D-40468 Düsseldorf | ICQ#: 110037733 GPG Public Key C2E467BB | Keyserver: www.keyserver.net

Thu Apr 30 09:42:13 2009 marc.girod [...] gmail.com - Correspondence added

On Fri Apr 24 05:18:17 2009, dheinric wrote: Show quoted text

> as an additional information it may be worth to know that the last > version that doesn't have this problem is 1.24.

Thanks. The oldest I have in my vob is 1.26... Show quoted text

> Otherwise: Any news on the issue?

Please try the last 'candidate' in: http://code.google.com/p/clearcase-cpan/downloads/list It has a fix for quoting. Now it doesn't restore the previous behaviour, rather discriminate. I.e. it will quote arguments containing single quotes with double quotes, e.g.: "Marc's fix", and ones containing double quotes with single quotes (which should solve the mkattr issue). And it leaves unquoted arguments with no special character... It has some fixes for other problems as well.

Thu Apr 30 09:42:13 2009 The RT System itself - Status changed from 'new' to 'open'

Mon May 04 02:32:26 2009 dirk.heinrichs.ext [...] nsn.com - Correspondence added

Subject:	Re: [rt.cpan.org #44522] ClearCase::Argv 1.44 doesn't quote anymore
Date:	Mon, 4 May 2009 08:31:26 +0200
To:	<bug-ClearCase-Argv [...] rt.cpan.org>
From:	"Heinrichs, Dirk (EXT-Capgemini - DE/Dusseldorf)" <dirk.heinrichs.ext [...] nsn.com>

Am Donnerstag, den 30.04.2009, 09:42 -0400 schrieb ext Marc Girod via RT: Show quoted text

> Please try the last 'candidate' in: > > http://code.google.com/p/clearcase-cpan/downloads/list > > It has a fix for quoting.

Looks good, mkattr works again. One minor issue: The debug output still doesn't show the single quotes around each argument anymore. Is this intentional? Bye... Dirk -- Dirk Heinrichs | Tel: +49 (0)162 234 3408 Configuration Manager | Fax: +49 (0)211 47068 111 Capgemini Deutschland | Mail: dirk.heinrichs@capgemini.com Wanheimerstraße 68 | Web: http://www.capgemini.com D-40468 Düsseldorf | ICQ#: 110037733 GPG Public Key C2E467BB | Keyserver: www.keyserver.net

Download signature.asc
application/pgp-signature 190b

Message body not shown because it is not plain text.

Wed May 06 05:22:59 2009 marc.girod [...] gmail.com - Correspondence added

On Mon May 04 02:32:26 2009, dheinric wrote: Show quoted text

> The debug output still doesn't show the single quotes around each > argument anymore. Is this intentional?

I guess so, but it must have been Dave's intention. The debug printing happens before quoting the arguments. It uses the array form of the command, while the quoting concerns its stringification. In any case, as I wrote earlier, the arguments are not quoted anymore unless there is a special reason, such as a character requiring quoting. This is the case of double-quote itself, especially in conjunction with mkattr.

Wed May 06 05:26:50 2009 dirk.heinrichs.ext [...] nsn.com - Correspondence added

Subject:	Re: [rt.cpan.org #44522] ClearCase::Argv 1.44 doesn't quote anymore
Date:	Wed, 6 May 2009 11:25:54 +0200
To:	<bug-ClearCase-Argv [...] rt.cpan.org>
From:	"Heinrichs, Dirk (EXT-Capgemini - DE/Dusseldorf)" <dirk.heinrichs.ext [...] nsn.com>

Am Mittwoch, den 06.05.2009, 05:23 -0400 schrieb ext Marc Girod via RT: Show quoted text

> On Mon May 04 02:32:26 2009, dheinric wrote: >

> > The debug output still doesn't show the single quotes around each > > argument anymore. Is this intentional?

> > I guess so, but it must have been Dave's intention. > The debug printing happens before quoting the arguments. > It uses the array form of the command, while the quoting concerns its > stringification. > > In any case, as I wrote earlier, the arguments are not quoted anymore > unless there is a special reason, such as a character requiring quoting. > This is the case of double-quote itself, especially in conjunction with > mkattr.

OK, thanks for clarifying this. Bye... Dirk -- Dirk Heinrichs | Tel: +49 (0)162 234 3408 Configuration Manager | Fax: +49 (0)211 47068 111 Capgemini Deutschland | Mail: dirk.heinrichs@capgemini.com Wanheimerstraße 68 | Web: http://www.capgemini.com D-40468 Düsseldorf | ICQ#: 110037733 GPG Public Key C2E467BB | Keyserver: www.keyserver.net

Download signature.asc
application/pgp-signature 190b

Message body not shown because it is not plain text.

Thu May 07 15:07:20 2009 marc.girod [...] gmail.com - Correspondence added

On Wed May 06 05:26:50 2009, dheinric wrote: Show quoted text

> OK, thanks for clarifying this.

Dave explained me why printing, in debug mode, the exact string sent to the ipc process was a good idea. I have to try it myself. I may well restore this in the next release, but I didn't want this to delay 1.45. Thanks, Marc

Sun May 10 08:58:07 2009 marc.girod [...] gmail.com - Broken in 1.24 added

Sun May 10 08:58:07 2009 marc.girod [...] gmail.com - Severity Important added

Sun May 10 08:58:07 2009 marc.girod [...] gmail.com - Fixed in 1.45 added