| Subject: | Fix for spurious "make test" warnings |
"make test" emits some spurious warnings on Perl 5.8.1. Fix attached.
diff -Naru XML-RSS-1.02.orig/t/2.0-generate.t XML-RSS-1.02/t/2.0-generate.t
--- XML-RSS-1.02.orig/t/2.0-generate.t 2003-01-18 03:13:42.000000000 +0200
+++ XML-RSS-1.02/t/2.0-generate.t 2003-11-21 02:17:12.000000000 +0200
@@ -3,8 +3,10 @@
use Test::More tests => 25;
+BEGIN {
use_ok("XML::RSS");
use_ok("POSIX");
+}
use constant DATE_TEMPLATE_LONG => "%Y-%m-%dT%H:%M:%S%z";
use constant DATE_TEMPLATE_SHORT => "%Y/%m/%d";
@@ -26,7 +28,7 @@
use constant RSS_CREATOR => "joeuser\@example.com";
use constant RSS_ITEM_TITLE => "This is an item";
-use constant RSS_ITEM_LINK => "http://example.com/$short_date";
+use constant RSS_ITEM_LINK => "http://example.com/" . &POSIX::strftime( DATE_TEMPLATE_SHORT, gmtime ); # "$short_date";
use constant RSS_ITEM_DESC => "Yadda yadda yadda";
diff -Naru XML-RSS-1.02.orig/t/encoding.t XML-RSS-1.02/t/encoding.t
--- XML-RSS-1.02.orig/t/encoding.t 2002-11-12 13:41:17.000000000 +0200
+++ XML-RSS-1.02/t/encoding.t 2003-11-21 02:14:04.000000000 +0200
@@ -18,7 +18,7 @@
"Default encoding for version $version" );
# UTF-8
- my $rss = XML::RSS->new( version => $version,
+ $rss = XML::RSS->new( version => $version,
encoding => 'UTF-8' );
isa_ok( $rss, 'XML::RSS' );
make_rss( $rss );
@@ -26,7 +26,7 @@
"Default encoding for version $version" );
# home brew
- my $rss = XML::RSS->new( version => $version,
+ $rss = XML::RSS->new( version => $version,
encoding => 'Fooey' );
isa_ok( $rss, 'XML::RSS' );
make_rss( $rss );
diff -Naru XML-RSS-1.02.orig/t/version.t XML-RSS-1.02/t/version.t
--- XML-RSS-1.02.orig/t/version.t 2002-11-12 12:41:50.000000000 +0200
+++ XML-RSS-1.02/t/version.t 2003-11-21 02:14:28.000000000 +0200
@@ -6,27 +6,25 @@
use XML::RSS;
-my @versions = qw( 0.9 0.91 1.0 );
-
my $rss = XML::RSS->new( version => '0.9' );
isa_ok( $rss, 'XML::RSS' );
make_rss( $rss );
like( $rss->as_string,
qr|<rdf:RDF[\d\D]+xmlns="http://my.netscape.com/rdf/simple/0.9/"[^>]*>|,
- "rdf tag for version $version" );
+ "rdf tag for version 0.9" );
-my $rss = XML::RSS->new( version => '0.91' );
+$rss = XML::RSS->new( version => '0.91' );
isa_ok( $rss, 'XML::RSS' );
make_rss( $rss );
like( $rss->as_string, qr/<rss version="0.91">/,
- "rss tag for version $version" );
+ "rss tag for version 0.91" );
-my $rss = XML::RSS->new( version => '1.0' );
+$rss = XML::RSS->new( version => '1.0' );
isa_ok( $rss, 'XML::RSS' );
make_rss( $rss );
like( $rss->as_string,
qr|<rdf:RDF[\d\D]+xmlns="http://purl.org/rss/1.0/"[^>]*>|,
- "rdf tag for version $version" );
+ "rdf tag for version 1.0" );
sub make_rss
{