Skip Menu |

This queue is for tickets about the ExtUtils-MakeMaker CPAN distribution.

Report information
The Basics
Id: 44504
Status: resolved
Priority: 0/
Queue: ExtUtils-MakeMaker

People
Owner: Nobody in particular
Requestors: adamk [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 6.48
Fixed in: (no value)



Subject: EU:MM assumes the existance of the binary 'false'
As seen below, EU:MM assumes the existance of 'false', resulting in a false error. D:\cpan\trunk\Module-Install>dmake Makefile out-of-date with respect to Makefile.PL Cleaning current config before rebuilding Makefile... dmake -f Makefile.old clean > NUL C:\strawberry\perl\bin\perl.exe "-Iinc" Makefile.PL include D:/cpan/trunk/Module-Install/inc/Module/Install.pm include inc/Module/Install/Metadata.pm include inc/Module/Install/Base.pm include inc/Module/Install/Makefile.pm include inc/Module/Install/Share.pm include inc/Module/Install/Compiler.pm include inc/Module/Install/WriteAll.pm Writing META.yml include inc/Module/Install/Win32.pm include inc/Module/Install/Can.pm include inc/Module/Install/Fetch.pm Writing Makefile for Module::Install ==> Your Makefile has been rebuilt. <== ==> Please rerun the dmake command. <== false 'false' is not recognized as an internal or external command, operable program or batch file. dmake: Error code 129, while making 'Makefile'
Subject: Re: [rt.cpan.org #44504] EU:MM assumes the existance of the binary 'false'
Date: Tue, 24 Mar 2009 03:32:54 -0700
To: bug-ExtUtils-MakeMaker [...] rt.cpan.org
From: Michael G Schwern <schwern [...] pobox.com>
Adam Kennedy via RT wrote: Show quoted text
> As seen below, EU:MM assumes the existance of 'false', resulting in a > false error.
... Show quoted text
> ==> Your Makefile has been rebuilt. <== > ==> Please rerun the dmake command. <== > false > 'false' is not recognized as an internal or external command, > operable program or batch file. > dmake: Error code 129, while making 'Makefile'
Huh. I guess nobody ever reported that since the build is supposed to fail anyway. -- 52. Not allowed to yell "Take that Cobra" at the rifle range. -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army http://skippyslist.com/list/
CC: adamk [...] cpan.org
Subject: Re: [rt.cpan.org #44504] EU:MM assumes the existance of the binary 'false'
Date: Wed, 25 Mar 2009 12:52:37 +1100
To: bug-ExtUtils-MakeMaker [...] rt.cpan.org
From: Adam Kennedy <adamkennedybackup [...] gmail.com>
Yup, I'd never bothered reporting it before, because I had more important things to deal with at the time. But this time around, I'm wondering if that failure is obscuring behaviour I need. Adam K 2009/3/24 Michael G Schwern via RT <bug-ExtUtils-MakeMaker@rt.cpan.org>: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=44504 > > > Adam Kennedy via RT wrote:
>> As seen below, EU:MM assumes the existance of 'false', resulting in a >> false error.
> > ... >
>> ==> Your Makefile has been rebuilt. <== >> ==> Please rerun the dmake command.  <== >> false >> 'false' is not recognized as an internal or external command, >> operable program or batch file. >> dmake:  Error code 129, while making 'Makefile'
> > Huh.  I guess nobody ever reported that since the build is supposed to fail > anyway. > > > -- > 52. Not allowed to yell "Take that Cobra" at the rifle range. >    -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army >           http://skippyslist.com/list/ > >
Done. I moved some code around in the process, unified some redundant generic tool defines between Windows, VMS and Unix. So please make sure things still work.
Subject: Re: [rt.cpan.org #44504] EU:MM assumes the existance of the binary 'false'
Date: Sun, 5 Apr 2009 05:05:16 +1100
To: bug-ExtUtils-MakeMaker [...] rt.cpan.org
From: Adam Kennedy <adamkennedybackup [...] gmail.com>
I'm seeing a ton of warnings on my trunk checkout on Win32. D:\eumm-trunk>perl -d Makefile.PL Loading DB routines from perl5db.pl version 1.28 Editor support available. Enter h or `h h' for help, or `perldoc perldebug' for more help. main::(Makefile.PL:24): my $PACKAGE = 'ExtUtils::MakeMaker'; DB<1> b 52 DB<2> c main::(Makefile.PL:52): my $MM = WriteMakefile( main::(Makefile.PL:53): NAME => $PACKAGE, main::(Makefile.PL:54): VERSION_FROM => "lib/$PACKAGE_FILE.pm", # finds $VERSION main::(Makefile.PL:55): PREREQ_PM => { %prereq, DB<2> s ExtUtils::MakeMaker::WriteMakefile(lib/ExtUtils/MakeMaker.pm:50): 50: Carp::croak "WriteMakefile: Need even number of args" if @_ % 2; DB<2> n ExtUtils::MakeMaker::WriteMakefile(lib/ExtUtils/MakeMaker.pm:52): 52: require ExtUtils::MY; DB<2> ExtUtils::MakeMaker::WriteMakefile(lib/ExtUtils/MakeMaker.pm:53): 53: my %att = @_; DB<2> ExtUtils::MakeMaker::WriteMakefile(lib/ExtUtils/MakeMaker.pm:55): 55: _verify_att(\%att); DB<2> ExtUtils::MakeMaker::WriteMakefile(lib/ExtUtils/MakeMaker.pm:57): 57: my $mm = MM->new(\%att); DB<2> Checking if your kit is complete... Looks good ExtUtils::MakeMaker::WriteMakefile(lib/ExtUtils/MakeMaker.pm:58): 58: $mm->flush; DB<2> s ExtUtils::MakeMaker::flush(lib/ExtUtils/MakeMaker.pm:948): 948: my $self = shift; DB<2> n ExtUtils::MakeMaker::flush(lib/ExtUtils/MakeMaker.pm:950): 950: my $finalname = $self->{MAKEFILE}; DB<2> x $self->{MAKEFILE} 0 undef DB<3> n ExtUtils::MakeMaker::flush(lib/ExtUtils/MakeMaker.pm:951): 951: print STDOUT "Writing $finalname for $self->{NAME}\n"; DB<3> x $finalname 0 undef DB<4> q 2009/4/3 Michael G Schwern via RT <bug-ExtUtils-MakeMaker@rt.cpan.org>: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=44504 > > > Done.  I moved some code around in the process, unified some redundant > generic tool defines between Windows, VMS and Unix.  So please make sure > things still work. >
Blarf. I see what's gone wrong. MM_Win32 inherits from MM_Any first, then MM_Unix. This bizarre arrangement is because MM_Unix still contains a lot of "universal" code, but in come places it has been moved into MM_Any. So if there's an MM_Any method available Win32 should use it, otherwise fall back to MM_Unix. The new init_others() is incomplete in this respect, there's still code in MM_Unix->init_others() that's universal, so I'll have to complete it.
Fixed and tested against the latest Strawberry and Cygwin.