Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Alien-SVN CPAN distribution.

Report information
The Basics
Id: 44495
Status: resolved
Priority: 0/
Queue: Alien-SVN

People
Owner: Nobody in particular
Requestors: rcoe [...] wi.rr.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: bug
Date: Mon, 23 Mar 2009 19:20:41 -0500
To: bug-Alien-SVN [...] rt.cpan.org
From: Rich Coe <rcoe [...] wi.rr.com>
(1) This package does not follow the CPAN convention of providing a Makefile.PL which the user runs perl against. That would be ok, except there are no instructions on what to do. (2) ran 'perl Build.PL' which created a script 'Build'. ran Build [ success ] ran Build test [ success ] ran Build install Running make install-lib /bin/ginstall -c -d /usr/lib/perl5/site_perl/5.10.0/i486-linux-thread-multi/Alien/SVN --prefix=/usr /bin/ginstall: unrecognized option `--prefix=/usr' Try `/bin/ginstall --help' for more information. /bin/ginstall --version install (GNU coreutils) 6.12 Investigation shows that the build script is trying to call make install-lib in the subversion directory and the Makefile entries for dirs have '--prefix=/usr' added as an extra argument.
inc/My/SVN/Builder.pm is outsmarting itself by Shell Quote Escaping the configure arguments. Patch is: --- inc/My/SVN/Builder.pm.orig 2010-05-26 15:10:33.000000000 -0400 +++ inc/My/SVN/Builder.pm 2010-05-26 14:52:15.000000000 -0400 @@ -104,7 +104,7 @@ _chdir_to_svn; - $self->_run("sh configure \Q@{[$self->notes('configure_args')]}") + $self->_run("sh configure @{[$self->notes('configure_args')]}") or do { warn "configuring SVN failed"; return 0 }; _chdir_back; --- Build.PL.orig 2010-05-26 15:13:17.000000000 -0400 +++ Build.PL 2010-05-26 14:53:20.000000000 -0400 @@ -81,7 +81,7 @@ $build->_default_configure_args ); - $build->notes("configure_args", \$configure_args); + $build->notes("configure_args", $configure_args); print "\n\nSubversion will now be configured.\n\n"; sleep 1; On Mon Mar 23 20:27:42 2009, rcoe@wi.rr.com wrote: Show quoted text
> > (1) This package does not follow the CPAN convention of providing a > Makefile.PL which the user runs perl against. > > That would be ok, except there are no instructions on what to do. > > (2) ran 'perl Build.PL' which created a script 'Build'. > ran Build [ success ] > ran Build test [ success ] > ran Build install > > Running make install-lib > /bin/ginstall -c -d /usr/lib/perl5/site_perl/5.10.0/i486-linux-thread- > multi/Alien/SVN --prefix=/usr > /bin/ginstall: unrecognized option `--prefix=/usr' > Try `/bin/ginstall --help' for more information. > > /bin/ginstall --version > install (GNU coreutils) 6.12 > > Investigation shows that the build script is trying to call > make install-lib in the subversion directory and the Makefile > entries > for dirs have '--prefix=/usr' added as an extra argument.
Please note that I am no longer actively maintaining Alien::SVN, my need for it is done (SVK is dead and I no longer use SVN). Several people have expressed interest in taking over maintenance but none have yet produced. On Mon Mar 23 20:27:42 2009, rcoe@wi.rr.com wrote: Show quoted text
> > (1) This package does not follow the CPAN convention of providing a > Makefile.PL which the user runs perl against. > > That would be ok, except there are no instructions on what to do.
Build.PL is the other CPAN convention. It has been around for eight years. That said, the project would gladly accept an INSTALL document. Show quoted text
> (2) ran 'perl Build.PL' which created a script 'Build'. > ran Build [ success ] > ran Build test [ success ] > ran Build install > > Running make install-lib > /bin/ginstall -c -d /usr/lib/perl5/site_perl/5.10.0/i486-linux-thread- > multi/Alien/SVN --prefix=/usr > /bin/ginstall: unrecognized option `--prefix=/usr' > Try `/bin/ginstall --help' for more information. > > /bin/ginstall --version > install (GNU coreutils) 6.12 > > Investigation shows that the build script is trying to call > make install-lib in the subversion directory and the Makefile > entries > for dirs have '--prefix=/usr' added as an extra argument.
There's been a number of unreleased fixes in this area of the code. Perhaps you can try them out and report back? http://github.com/schwern/alien-svn
On Wed May 26 15:13:47 2010, BLHOTSKY wrote: Show quoted text
> inc/My/SVN/Builder.pm is outsmarting itself by Shell Quote Escaping the > configure arguments. > > --- inc/My/SVN/Builder.pm.orig 2010-05-26 15:10:33.000000000 -0400 > +++ inc/My/SVN/Builder.pm 2010-05-26 14:52:15.000000000 -0400 > @@ -104,7 +104,7 @@ > > _chdir_to_svn; > > - $self->_run("sh configure \Q@{[$self->notes('configure_args')]}") > + $self->_run("sh configure @{[$self->notes('configure_args')]}") > or do { warn "configuring SVN failed"; return 0 }; > > _chdir_back;
Thanks, this has already been done in the repository. Please see http://github.com/schwern/alien-svn Show quoted text
> --- Build.PL.orig 2010-05-26 15:13:17.000000000 -0400 > +++ Build.PL 2010-05-26 14:53:20.000000000 -0400 > @@ -81,7 +81,7 @@ > $build->_default_configure_args > ); > > - $build->notes("configure_args", \$configure_args); > + $build->notes("configure_args", $configure_args); > > print "\n\nSubversion will now be configured.\n\n"; > sleep 1;
This appears to be a mistake in your patch? $configure_args was never passed as a reference.
On Wed May 26 20:32:33 2010, MSCHWERN wrote: Show quoted text
> > Thanks, this has already been done in the repository. Please see > http://github.com/schwern/alien-svn
Cool. Show quoted text
> This appears to be a mistake in your patch? $configure_args was never > passed as a reference. >
Indeed, you are right.. Apologies.
As I haven't heard back, I'm going to presume this is ok and close it up. Please re-open if that isn't the case.