Skip Menu |

This queue is for tickets about the CPANPLUS-Dist-RPM CPAN distribution.

Report information
The Basics
Id: 44424
Status: new
Priority: 0/
Queue: CPANPLUS-Dist-RPM
People
Owner: Nobody in particular
Requestors: hergenhahn [...] denic.de
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)
Attachments
smime.p7s

History Show all quoted text
  Thu Mar 19 11:11:41 2009 hergenhahn [...] denic.de - Ticket created
Subject: bug: --skiptest not honoured
Date: Thu, 19 Mar 2009 16:11:11 +0100
To: bug-CPANPLUS-Dist-RPM [...] rt.cpan.org
From: Sven Hergenhahn <hergenhahn [...] denic.de>
Hi, thanks for providing this module. I have however seen a few things that make cpan2dist not work for me under certain conditions: 1) a bug 345c345 < . $self->specpath, --- Show quoted text
> . $self->status->specpath,
2) My main problem: the --skiptest from cpan2dist seems to be ignored by your module. Apart from that, a failed build then spits out the following errors: [...] + cd /usr/src/redhat + cd Net-Ping-2.35 + make test [...] Result: FAIL Failed 3/15 test programs. 19/106 subtests failed. make: *** [test_dynamic] Error 255 error: Bad exit status from /var/tmp/rpm-tmp.45443 (%check) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.45443 (%check) [MSG] extra files installed, fixing spec file Use of uninitialized value in substitution (s///) at /usr/lib/perl5/site_perl/5.8.8/CPANPLUS/Dist/RPM.pm line 364. Use of uninitialized value in split at /usr/lib/perl5/site_perl/5.8.8/CPANPLUS/Dist/RPM.pm line 365. I'm behind a firewall and some net-test will always fail. Therefore I need the --skiptest. The two warnings seem to come from $1 not being set beforehand. 3) a minor nuisance: why do you not use the "standard" directories SPECS, SRPMS and RPMS/*? 321c321 < $status->specpath($status->rpmdir . '/' . $status->rpmname . '.spec'); --- Show quoted text
> $status->specpath($status->rpmdir . '/SPECS/' . $status->rpmname . > '.spec');
some other lines need fixing there as well... 4) eyecandy: 140c140 < msg( "writing specfile for '$self->distname'..." ); --- Show quoted text
> msg( "writing specfile for '" . $status->distname . "'");
otherwise it will not correctly display the module name. Again - thanks for this and if I can be of any help here, I'm glad to do it, but you are probably much deeper in your own code here... Cheers, Sven -- Sven Hergenhahn IT-Services DENIC eG GERMANY
Download smime.p7s
application/x-pkcs7-signature 3.9k

Message body not shown because it is not plain text.

  Mon Mar 23 16:41:55 2009 hergenhahn [...] denic.de - Correspondence added
Subject: Re: [rt.cpan.org #44424] AutoReply: bug: --skiptest not honoured, patch offered
Date: Mon, 23 Mar 2009 13:53:38 +0100
To: Bugs in CPANPLUS-Dist-RPM via RT <bug-CPANPLUS-Dist-RPM [...] rt.cpan.org>
From: Sven Hergenhahn <hergenhahn [...] denic.de>
Hi, I have a patch that will honour --skiptest by not writing the %check section into the specfile. Here's the patch: # diff RPM.pm.orig RPM.pm 92c92 < packager --- Show quoted text
> packager skiptest
102d101 < 135d133 < 140c138 < msg( "writing specfile for '$self->distname'..." ); --- Show quoted text
> msg( "writing specfile for '" . $status->distname . "'");
142a141,146 Show quoted text
> # honouring skiptest option > # TODO: honouring noskiptest > if ($conf->get_conf('skiptest')) { > msg 'Skiptest is set - omitting %check section in specfile'; > $status->skiptest(1); > }
321c325 < $status->specpath($status->rpmdir . '/' . $status->rpmname . '.spec'); --- Show quoted text
> $status->specpath($status->rpmdir . '/SPECS/' . $status->rpmname . '.spec');
345c349 < . $self->specpath, --- Show quoted text
> . $self->status->specpath,
383a388 Show quoted text
> skiptest => $conf->get_conf('skiptest'),
579a585 Show quoted text
> [% IF (!status.skiptest) -%]
581a588 Show quoted text
> [% END -%]
Hope you like it. Cheers, Sven
Download smime.p7s
application/x-pkcs7-signature 3.9k

Message body not shown because it is not plain text.