Skip Menu |

This queue is for tickets about the Mobile-Wurfl CPAN distribution.

Report information
The Basics
Id: 44199
Status: rejected
Priority: 0/
Queue: Mobile-Wurfl
People
Owner: Nobody in particular
Requestors: jonas.pasche [...] skytel.de
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Mar 16 11:29:39 2009 jonas.pasche [...] skytel.de - Ticket created
Subject: sub rebuild_tables broken
Date: Mon, 16 Mar 2009 16:29:09 +0100
To: bug-Mobile-Wurfl [...] rt.cpan.org
From: Jonas Pasche <jonas.pasche [...] skytel.de>
sub rebuild_tables compares the result of get_local_stats() with the result of last_update(). Unfortunately it expects get_local_stats to return a timestamp while in fact get_local_stats returns an _array_ of the file size and the time stamp of wurfl.xml. The problem can be easily fixed this way: --- Mobile/Wurfl.pm.orig 2009-03-16 16:18:14.000000000 +0100 +++ Mobile/Wurfl.pm 2009-03-16 16:28:25.000000000 +0100 @@ -175,7 +175,7 @@ { my $self = shift; - my $local = $self->get_local_stats(); + my $local = ($self->get_local_stats())[1]; my $last_update = $self->last_update(); if ( $local <= $last_update ) {
  Tue May 12 17:08:38 2009 valdez [...] cpan.org - Correspondence added
Hi Jonas, you probably submitted your request to the wrong place; my module is Mobile::WURFL, while your patch is for Mobile::Wurfl. Bye, Valerio On Mon Mar 16 11:29:39 2009, jonas.pasche@skytel.de wrote: Show quoted text
> sub rebuild_tables compares the result of get_local_stats() with the > result of last_update(). Unfortunately it expects get_local_stats to > return a timestamp while in fact get_local_stats returns an _array_ of > the file size and the time stamp of wurfl.xml. > > The problem can be easily fixed this way: > > --- Mobile/Wurfl.pm.orig 2009-03-16 16:18:14.000000000 +0100 > +++ Mobile/Wurfl.pm 2009-03-16 16:28:25.000000000 +0100 > @@ -175,7 +175,7 @@ > { > my $self = shift; > > - my $local = $self->get_local_stats(); > + my $local = ($self->get_local_stats())[1]; > my $last_update = $self->last_update(); > if ( $local <= $last_update ) > { > >
  Tue May 12 17:08:39 2009 The RT System itself - Status changed from 'new' to 'open'
  Tue May 12 17:08:40 2009 valdez [...] cpan.org - Status changed from 'open' to 'rejected'