Skip Menu |

This queue is for tickets about the XML-GDOME CPAN distribution.

Report information
The Basics
Id: 4410
Status: resolved
Priority: 0/
Queue: XML-GDOME

People
Owner: TJMATHER [...] cpan.org
Requestors: gbjk [...] thermeon.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.83
Fixed in: (no value)



Subject: Makefile will die with gdome2 version 0.8.0 or higher
In XML-GDOME-0.83 Because of this: die "VERSION" unless $major == 0 && $minor == 7 && $point >= 2; ( Makefile.PL line 20 ) The Makefile.PL will die if the version reported by gdome-config is greater than 7 ( 0.8.0 ) Was this intentional ? Nothing in the docs metions not using a version higher than 7.9, only not using a version lower than 7.2
Hi, I haven't tested XML::GDOME with 0.8.0 - so I know of no reason why it shouldn't work with gdome2 0.8.0. Have you been able to get it to work if you change to die "VERSION" unless $major == 0 && $minor >= 7 && $point >= 2; By working i mean it passes "make test" If it does work with 0.8.0, then please let me knoe and I will update Makefile.PL Thanks, TJ [guest - Mon Nov 17 12:08:28 2003]: Show quoted text
> In XML-GDOME-0.83 > > Because of this: > > die "VERSION" unless $major == 0 && $minor == 7 && $point >= 2; > > ( Makefile.PL line 20 ) > > The Makefile.PL will die if the version reported by gdome-config is > greater than 7 ( 0.8.0 ) > > Was this intentional ? > > Nothing in the docs metions not using a version higher than 7.9, only > not using a version lower than 7.2
[TJMATHER - Mon Nov 17 15:13:03 2003]: Show quoted text
> if you change to > > die "VERSION" unless $major == 0 && $minor >= 7 && $point >= 2;
I did change the Makefile.PL to install it by commenting that version line, but I hit dependancies on libxslt versions, so I'm just about to install a more recent libxslt now. No, that wouldn't Makefile.PL change proposed wouldn't work though... die "VERSION" unless $major == 0 && $minor >= 7 && $point >= 2; 8.0, 8.1 wouldn't pass.
[guest - Tue Nov 18 04:41:32 2003]: Show quoted text
> ... I hit dependancies on libxslt versions, so I'm just about to > install a more recent libxslt now.
Yikes, bad memory. I hit libxslt issues installing XML::GDOME::XSLT, not XML::GDOME. XML::GDOME installed fine, but I haven't done much testing with it. G
Show quoted text
> XML::GDOME installed fine, but I haven't done much testing with it.
Not here (perl 5.8.1, GDOME 0.8.0). See attached patch for my Makefile.PL workaround. However test 6 in t/01_basic.t fails: # Failed test 6 in t/01_basic.t at line 45 # t/01_basic.t line 45 is: ok($@ =~ m!NAMESPACE_ERR!); I checked and the eval block doesn't die, there's no exception thrown. Also, there's another warning from t/11_encode.t: Use of uninitialized value in subroutine entry at t/11_encode.t line 39.
--- Makefile.PL~ 2002-09-15 18:50:55.000000000 +0300 +++ Makefile.PL 2003-11-28 00:12:02.000000000 +0200 @@ -17,7 +17,9 @@ print "running gdome-config... "; my $ver = backtick('gdome-config --version'); my ($major, $minor, $point) = $ver =~ /(\d+).(\d+)\.(\d+)/g; - die "VERSION" unless $major == 0 && $minor == 7 && $point >= 2; + die "VERSION" unless + $major > 0 || + ($major == 0 && (($minor == 7 && $point >= 2) || $minor >= 8)); $config{LIBS} ||= backtick('gdome-config --libs'); $config{INC} ||= backtick('gdome-config --cflags'); print "ok\n";
Which version of libxml2 are you running? Perhaps there was a change in the way that libxml2 or gdome2 throws namespare errors? Show quoted text
> # Failed test 6 in t/01_basic.t at line 45 > # t/01_basic.t line 45 is: ok($@ =~ m!NAMESPACE_ERR!);
[TJMATHER - Fri Nov 28 02:29:32 2003]: Show quoted text
> Which version of libxml2 are you running?
libxml2 2.5.11 on Fedora Core 1. Show quoted text
> Perhaps there was a change in > the way that libxml2 or gdome2 throws namespare errors?
Probably, dunno. (Please add me to Cc ticket watchers for this bug, I'm not able to do it myself.)
This should be fixed in XML::GDOME version 0.84 according to the changelog.