Bug #4408 for Devel-ptkdb: minor adaptations for Tk-804.025

Mon Nov 17 10:07:09 2003 Marek.Rouchal [...] gmx.net - Ticket created

Subject:

minor adaptations for Tk-804.025

I have perl-5.8.2 on Sparc/Solaris 7 (gcc-3.2.3, ithreads, shared libperl) with Tk-804.025_beta6. The syntax checking in that Tk is stricter and requires minor adaptations in ptkdb.pm. I think this should also work with previous Tk's. Best regards, Marek --- ptkdb.pm 2003-06-26 15:42:49.000000000 +0200 +++ /opt/perl_5.8.2/share/lib/Devel/ptkdb.pm 2003-11-17 15:59:25.473881000 +0100 @@ -2281,7 +2281,7 @@ # take the last leaf of the pathname $frm = $self->{'breakpts_table'}->Frame(-relief => 'raised') ; - $upperFrame = $frm->Frame()->pack(-side => 'top', '-fill' => 'x', 'expand' => 1) ; + $upperFrame = $frm->Frame()->pack(-side => 'top', '-fill' => 'x', '- expand' => 1) ; $btn = $upperFrame->Checkbutton(-text => "$btnName:$index", @@ -2296,7 +2296,7 @@ $btn = $upperFrame->Button(-text => "Goto", -command => sub { $self- Show quoted text

>set_file($fname, $index) ; } ) ;

$btn->pack(-side => 'left', -fill => 'x', -expand => 1) ; - $lowerFrame = $frm->Frame()->pack(-side => 'top', '-fill' => 'x', 'expand' => 1) ; + $lowerFrame = $frm->Frame()->pack(-side => 'top', '-fill' => 'x', '- expand' => 1) ; $lowerFrame->Label(-text => "Cond:")->pack(-side => 'left') ;

Mon Nov 17 20:04:25 2003 aepage [...] users.sourceforge.net - Correspondence added

Subject:	Re: [cpan #4408] minor adaptations for Tk-804.025
From:	"Andrew E. Page" <aepage [...] users.sourceforge.net>
To:	bug-Devel-ptkdb [...] rt.cpan.org
Date:	17 Nov 2003 20:03:54 -0500
RT-Send-Cc:

I do not accept unsolicited patches. On Mon, 2003-11-17 at 10:07, via RT wrote: Show quoted text

> > This message about Devel-ptkdb was sent to you by MAREKR <MAREKR@cpan.org> via rt.cpan.org > > Full context and any attached attachments can be found at: > <URL: https://rt.cpan.org/Ticket/Display.html?id=4408 > > > I have perl-5.8.2 on Sparc/Solaris 7 (gcc-3.2.3, ithreads, shared > libperl) with Tk-804.025_beta6. The syntax checking in that Tk is > stricter and requires minor adaptations in ptkdb.pm. I think this > should also work with previous Tk's. > > Best regards, > > Marek > > > --- ptkdb.pm 2003-06-26 15:42:49.000000000 +0200 > +++ /opt/perl_5.8.2/share/lib/Devel/ptkdb.pm 2003-11-17 > 15:59:25.473881000 +0100 > @@ -2281,7 +2281,7 @@ > # take the last leaf of the pathname > > $frm = $self->{'breakpts_table'}->Frame(-relief => 'raised') ; > - $upperFrame = $frm->Frame()->pack(-side => 'top', '-fill' > => 'x', 'expand' => 1) ; > + $upperFrame = $frm->Frame()->pack(-side => 'top', '-fill' => 'x', '- > expand' => 1) ; > > > $btn = $upperFrame->Checkbutton(-text => "$btnName:$index", > @@ -2296,7 +2296,7 @@ > $btn = $upperFrame->Button(-text => "Goto", -command => sub { $self-

> >set_file($fname, $index) ; } ) ;

> $btn->pack(-side => 'left', -fill => 'x', -expand => 1) ; > > - $lowerFrame = $frm->Frame()->pack(-side => 'top', '-fill' > => 'x', 'expand' => 1) ; > + $lowerFrame = $frm->Frame()->pack(-side => 'top', '-fill' => 'x', '- > expand' => 1) ; > > $lowerFrame->Label(-text => "Cond:")->pack(-side => 'left') ;

Wed Nov 19 02:43:26 2003 Marek.Rouchal [...] gmx.net - Correspondence added

[aepage@users.sourceforge.net - Mon Nov 17 20:04:25 2003]: Show quoted text

> I do not accept unsolicited patches.

So what? And how do you think people should use Devel::ptkdb with the new Tk? I admit, the Tk 804.025 is still beta, but I do not think its behaviour wrt. accepting "-expand" rather than "expand" will change. So your current ptkdb.pm is broken. Face it. So you don't want others to contribute to your stuff? Well then, place a big disclaimer in your distribution so that people do not waste their time. -Marek