Skip Menu |

This queue is for tickets about the Net-Async-FTP CPAN distribution.

Report information
The Basics
Id: 44063
Status: resolved
Priority: 0/
Queue: Net-Async-FTP

People
Owner: Nobody in particular
Requestors: frank.wiegand [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.01
Fixed in: 0.02



Subject: net-async-ftp assumes utc timezone
% export TZ=CET % make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00use................ok t/01login..............ok t/02connect............ok t/10commands-simple....ok t/11commands-stat......1/12 # Failed test '@stats after 211 parsed' # at t/11commands-stat.t line 97. # Structures begin differing at: # $got->[0]{mtime} = '1107298800' # $expected->[0]{mtime} = '1107302400' # Failed test '@stats after 211 on dir parsed' # at t/11commands-stat.t line 126. # Structures begin differing at: # $got->[0]{mtime} = '1107212400' # $expected->[0]{mtime} = '1107216000' # Looks like you failed 2 tests of 12. t/11commands-stat...... Dubious, test returned 2 (wstat 512, 0x200) Failed 2/12 subtests t/12commands-retr......ok t/13commands-stor......ok t/14commands-list......1/16 # Failed test '@files after 226' # at t/14commands-list.t line 93. # Structures begin differing at: # $got->[0]{mtime} = '1107298800' # $expected->[0]{mtime} = '1107302400' # Looks like you failed 1 test of 16. t/14commands-list...... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/16 subtests Test Summary Report ------------------- t/11commands-stat (Wstat: 512 Tests: 12 Failed: 2) Failed tests: 9, 12 Non-zero exit status: 2 t/14commands-list (Wstat: 256 Tests: 16 Failed: 1) Failed test: 8 Non-zero exit status: 1 Files=8, Tests=51, 0 wallclock secs ( 0.05 usr 0.01 sys + 0.55 cusr 0.07 csys = 0.68 CPU) Result: FAIL Failed 2/8 test programs. 3/51 subtests failed. make: *** [test_dynamic] Error 1 % export TZ= % make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00use................ok t/01login..............ok t/02connect............ok t/10commands-simple....ok t/11commands-stat......ok t/12commands-retr......ok t/13commands-stor......ok t/14commands-list......ok All tests successful. Files=8, Tests=51, 1 wallclock secs ( 0.05 usr 0.00 sys + 0.56 cusr 0.06 csys = 0.67 CPU) Result: PASS Thanks, Frank
On Thu Mar 12 05:23:17 2009, frank.wiegand wrote: Show quoted text
> # Structures begin differing at: > # $got->[0]{mtime} = '1107298800' > # $expected->[0]{mtime} = '1107302400'
Ah yes, you spotted that. I had noticed lots of FAILs yesterday when I uploaded it, but it took until the testers links updated for me to see what the FAILs are. I'm using File::Listing to parse the FTP responses and get those times. I'll have a look and see if it can be given a timezone. If not, perhaps some %ENV fiddling may be in order. Failing that, I'll just have to not hardcode the times in the tests, instead use POSIX::mktime() to create it. -- Paul Evans
Should now be fixed in 0.02 -- Paul Evans