| Subject: | Buffer overflow leading to crashes on 64 bits arch when loading a brain |
Hi,
On my 64-bit system, I get the following warning when compiling :
In function ‘fread’,
inlined from ‘load_dictionary’ at libmegahal.c:1388,
inlined from ‘load_model’ at libmegahal.c:2018,
inlined from ‘load_personality’ at libmegahal.c:3291,
inlined from ‘change_personality’ at libmegahal.c:3340:
/usr/include/bits/stdio2.h:285: warning : call to ‘__fread_chk_warn’
declared with attribute warning: fread called with bigger size * nmemb
than length of destination buffer
The module also aborts violently when loading a brain file (e.g. when
running the testsuite twice).
The attached patch fix the warning and the crashes.
Vincent.
| Subject: | libmegahal-load-size.patch |
--- libmegahal.c 2008-01-24 18:21:24.000000000 +0100
+++ libmegahal.c 2009-03-05 17:44:03.000000000 +0100
@@ -1383,7 +1383,7 @@
void load_dictionary(FILE *file, DICTIONARY *dictionary)
{
unsigned int i;
- int size;
+ BYTE4 size;
fread(&size, sizeof(BYTE4), 1, file);
progress("Loading dictionary", 0, 1);