Bug #43843 for Config-IniFiles: Allow comments on a line that contains parameters

Wed Mar 04 12:58:24 2009 franck.mail [...] dthconnex.com - Ticket created

Subject:

Allow comments on a line that contains parameters

Hi, Would it be possible to allow comments on lines that contains parameters? I mean I like to use such a declaration: param1 = value1 ; param1 must be specified in ns rather than adding all my comments before the section name. This bug has been reported on Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=513510 Regards,

Tue Apr 14 19:59:36 2009 cbanker [...] gmail.com - Correspondence added

From:

cbanker [...] gmail.com

I agree that this would be a very useful feature. There don't seem to be any modules on the archive that are able to do both read/write and handle inline comments. Seems like it should be possible to handle inline comments using regex's. On Wed Mar 04 12:58:24 2009, thialme wrote: Show quoted text

> Hi, > > Would it be possible to allow comments on lines that contains > parameters? > > I mean I like to use such a declaration: > > param1 = value1 ; param1 must be specified in ns > > rather than adding all my comments before the section name. > > This bug has been reported on Debian: > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=513510 > > Regards,

Tue Apr 14 19:59:36 2009 The RT System itself - Status changed from 'new' to 'open'

Thu Mar 25 07:31:16 2010 SHLOMIF [...] cpan.org - Correspondence added

If you're interested in this, please submit a patch with a testcase. It seems like a desirable feature. Regards, -- Shlomi Fish

Mon Mar 29 03:44:26 2010 franck [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #43843] Allow comments on a line that contains parameters
Date:	Mon, 29 Mar 2010 09:43:34 +0200
To:	bug-Config-IniFiles [...] rt.cpan.org
From:	Franck Joncourt <franck [...] debian.org>

Le 25/03/2010 12:31, Shlomi Fish via RT a écrit : Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=43843> > > If you're interested in this, please submit a patch with a testcase. It > seems like a desirable feature.

I will try to find the time to do that. But I am not sure when :) Regards, --- Franck

Sat Aug 14 09:23:49 2010 SHLOMIF [...] cpan.org - Correspondence added

On Mon Mar 29 03:44:26 2010, franck@debian.org wrote: Show quoted text

> Le 25/03/2010 12:31, Shlomi Fish via RT a écrit :

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=43843> > > > > If you're interested in this, please submit a patch with a testcase. It > > seems like a desirable feature.

> > I will try to find the time to do that. But I am not sure when :) >

Hi! Any news about it? Regards, -- Shlomi Fish Show quoted text

> Regards, > > --- > Franck >

Sun Jan 30 03:02:26 2011 SHLOMIF [...] cpan.org - Correspondence added

This issue is now fixed thanks to a patch provided by Peter Xu. Quoting from the Config-IniFiles-2.66 changes: Version 2.66: ( Sat Jan 29 18:28:53 IST 2011 ) ------------------------------------------------- * Add support for the handle_trailing_comment option to support trailing comments at the end of a param=value line. - Fixes https://rt.cpan.org/Public/Bug/Display.html?id=43843 . - Original patch by Peter Xu. - Some comments and corrections of the patch by Shlomi Fish (the current Config-IniFiles maintainer.)

Sun Jan 30 03:02:27 2011 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'