Bug #43823 for SVN-Notify: ticket_map broken since 2.73

On Mar 3, 2009, at 5:56 PM, Dirk Olmes via RT wrote: Show quoted text
I just checked in a test for this and is passes. Can you check it out from SVN and make sure all the tests pass for you? svn co https://svn.kineticode.com/SVN-Notify/trunk SVN-Notify cd SVN-Notify perl Build.PL ./Build test Thanks, David

On Mar 4, 2009, at 6:55 PM, Dirk Olmes via RT wrote: Show quoted text
I wrote a simple shell script: #!/bin/sh echo $@; Then I ran it like this: % try.sh '\b[Mm]antis-(\d+)\b=http://server/mantisbt/view.php?id= %s' It's output: [Mm]antis-(\d+=http://server/mantisbt/view.php?id=%s So I think you need to escape some stuff. Try this: % try.sh '\\b[Mm]antis-(\d+))\b=http://server/mantisbt/view.php?id=%s' \b[Mm]antis-(\d+)=http://server/mantisbt/view.php?id=%s I have no idea why some backslashed need escaping and some not, or why one ) disappears, but there you go. I suggest that you do some experimentation with the argument until it comes out right. That's the only thing I can think of. :-( Best, David

On Mar 4, 2009, at 7:35 PM, Dirk Olmes via RT wrote: Show quoted text
Okay, thanks for being persistent. Try applying this patch and see what SVN::Notify thinks the regex is: Index: Notify.pm =================================================================== --- Notify.pm (revision 4332) +++ Notify.pm (working copy) @@ -1593,6 +1593,7 @@ my $has_header = 0; $self->run_ticket_map( sub { my ($regex, $url) = @_; + print STDERR "Regex: '$regex'\n"; while ($msg =~ /$regex/ig) { unless ($has_header) { print $out "\nTicket Links:\n:-----------\n"; Best, David

On Mar 5, 2009, at 12:13 AM, Dirk Olmes via RT wrote: Show quoted text
Is that correct? D

On Mar 5, 2009, at 4:25 PM, Dirk Olmes via RT wrote: Show quoted text
That at least is easy to fix; done in r4596. As for the other, I still can't replicate it. :-( To test it, I created this simple script: #!/usr/local/bin/perl -w use strict; use warnings; use feature ':5.10'; print qq{theory 2004-04-20 01:33:35 -0700 (Tue, 20 Apr 2004) 103 mantis-176: Neuer Lizenztyp: Gastlizenz }; Then I put some debugging in SVN::Notify: Index: Notify.pm =================================================================== --- Notify.pm (revision 4596) +++ Notify.pm (working copy) @@ -1593,11 +1593,13 @@ my $has_header = 0; $self->run_ticket_map( sub { my ($regex, $url) = @_; + print STDERR $regex, $/; while ($msg =~ /$regex/ig) { unless ($has_header) { print $out "\nTicket Links:\n------------\n"; $has_header = 1; } + printf STDERR " $url\n", $2 || $1; printf $out " $url\n", $2 || $1; } } ); Then I ran it like so: % perl -Ilib ./bin/svnnotify -p /usr/local/bricolage -r 2 -l ~/bin/try --ticket-map '\b[Mm]antis-(\d+)\b=http://server/mantisbt/view.php?id= %s' --to david@kineticode.com \b[Mm]antis-(\d+)\b http://server/mantisbt/view.php?id=176 You can see there how it output the link, yes? I got the same result with Perl 5.8.8. The only other thing I can think of is if there is some sort of encoding issue that's causing problems. Is that log message all ASCII characters? Has something perhaps been stripped out in our exchanges? Otherwise, I'm at a loss. :-( Best, David

On Mar 10, 2009, at 10:56 AM, Dirk Olmes via RT wrote: Show quoted text
Sorry, ~/bin/try was the script I pasted in, and /usr/local/bricolage was just a directory I pointed at to keep SVN::Notify from bitching about not having an SVN root. Show quoted text
Interesting. Wait, you get the number 2 instead of a link in the message? I see this in an earlier email from you: Ticket Links: :----------- 2 WTF is that 2 doing there? Something is funky with the printf to $out there. Show quoted text
Is it a vendor build, or did you compile it yourself? Show quoted text
Okay, strike that idea, then. Best, David

On Mar 11, 2009, at 1:36 PM, Dirk Olmes via RT wrote: Show quoted text
You're going to have to do some debugging by putting `print STDERR` statements here and there to see if you can figure out WTF is going on. I'm out of ideas, I'm afraid, though I *would* suggest trying to compile your own Perl rather than rely on Gentoo's compile, which likely applies patches that break Perl. Best, David

On Mar 17, 2009, at 8:35 PM, Dirk Olmes via RT wrote: Show quoted text
Yep, that's the culprit. Bizarre that the object isn't shifted off by the `shift` before sprintf does its thing. I'm going to change it to: sub PRINTF { my $self = shift; $self->PRINT( sprintf(@_) ); } And that should do the trick. Nice debugging; thanks! David

Show quoted text
David, what about getting around the whole PRINTF magic and doing print $out " ", sprintf ($url, $2 || $1), "\n"; in Notify.pm around line 1593? This works fine for me. -dirk

On Mar 19, 2009, at 6:55 AM, Dirk Olmes via RT wrote: Show quoted text
I've now replicated the issue in a test, and made it pass with what I sent a few minutes ago. So I think we're finally good to go! Thanks, David

David Wheeler via RT wrote: Show quoted text
David, does this fix warrant a new release? I'd like to update my production server using this bugfix. -dirk