Bug #4376 for Tk-PathEntry: bug in test script?

Thu Nov 13 02:40:44 2003 Marek.Rouchal [...] gmx.net - Ticket created

Subject:

bug in test script?

I have perl-5.8.2, ithreads, defined-or patch, latest Tk (804.025_beta5) on Solaris 7/Sparc compiled with gcc-3.2.3. I see a test failure: t/base......Xlib: extension "RENDER" missing on display "tamarix:16.0". t/base......ok t/dialog....Xlib: extension "RENDER" missing on display "tamarix:16.0". Your choice: /home/hwadm/....... t/dialog....ok 1/3Can't use string ("ignored") as an ARRAY ref while "strict refs" in use at /opt/perl_5.8.2/lib/sun4-solaris-thread- multi/Tk/FBox.pm line 940. t/dialog....dubious Test returned status 255 (wstat 65280, 0xff00) DIED. FAILED tests 2-3 Failed 2/3 tests, 33.33% okay t/timex....._TK_EXIT_(0) BEGIN failed--compilation aborted at t/timex.t line 26. t/timex.....dubious This patch seems to solve the issues: diff -ruN Tk-PathEntry-2.17/t/dialog.t Tk-PathEntry-2.17.p1/t/dialog.t --- Tk-PathEntry-2.17/t/dialog.t 2001-05-04 20:56:23.000000000 +0200 +++ Tk-PathEntry-2.17.p1/t/dialog.t 2003-11-12 17:25:47.462024000 +0100 @@ -43,7 +43,7 @@ my $f2 = $top->getSaveFile(-title => "File to save", -initialfile => "$ENV{HOME}/.cshrc", -defaultextension => "ignored", - -filetypes => ["ignored"], + -filetypes => [["ignored", "*"]], ); yc($f2); ok(1); diff -ruN Tk-PathEntry-2.17/t/timex.t Tk-PathEntry-2.17.p1/t/timex.t --- Tk-PathEntry-2.17/t/timex.t 2001-12-03 15:10:15.000000000 +0100 +++ Tk-PathEntry-2.17.p1/t/timex.t 2003-11-13 08:35:39.758024000 +0100 @@ -11,6 +11,7 @@ use Tk; use Tk::PathEntry; +my $ok; BEGIN { if (!eval q{ use Test; @@ -21,11 +22,15 @@ print "# tests only work with installed Test and Timex::Project module\n"; print "1..1\n"; print "ok 1\n"; - exit; + $ok = 0; + } else { + $ok = 1; } } -BEGIN { plan tests => 2 } +exit 0 unless($ok); + +plan tests => 2; my $timex_project_text = <<'EOF'; #PJ1 -*- project -*- But: When choosing file "startx" from my home directory in t/dialog.t, then I get an error box saying: File "/home/hwadm/startxignored" does not exist. With other files, this does not happen, but I did not find out the root cause. Bug or feature? ;-) Best regards, Marek

Thu Nov 13 06:11:14 2003 slaven [...] rezic.de - Correspondence added

From:	Slaven Rezic <slaven [...] rezic.de>
CC:	"AdminCc of cpan Ticket #4376": ;
To:	bug-Tk-PathEntry [...] rt.cpan.org
Subject:	Re: [cpan #4376] bug in test script?
Date:	Thu, 13 Nov 2003 11:06:39 +0000
RT-Send-Cc:

" via RT" <bug-Tk-PathEntry@rt.cpan.org> wrote: Show quoted text

> > This message about Tk-PathEntry was sent to you by MAREKR <MAREKR@cpan.org> via rt.cpan.org > > Full context and any attached attachments can be found at: > <URL: https://rt.cpan.org/Ticket/Display.html?id=4376 > > > I have perl-5.8.2, ithreads, defined-or patch, latest Tk (804.025_beta5) > on Solaris 7/Sparc compiled with gcc-3.2.3. > I see a test failure: > > t/base......Xlib: extension "RENDER" missing on display "tamarix:16.0". > t/base......ok > > t/dialog....Xlib: extension "RENDER" missing on display "tamarix:16.0". > Your choice: /home/hwadm/....... > t/dialog....ok 1/3Can't use string ("ignored") as an ARRAY ref > while "strict refs" in use at /opt/perl_5.8.2/lib/sun4-solaris-thread- > multi/Tk/FBox.pm line 940. > t/dialog....dubious > > Test returned status 255 (wstat 65280, 0xff00) > DIED. FAILED tests 2-3 > Failed 2/3 tests, 33.33% okay > t/timex....._TK_EXIT_(0) > BEGIN failed--compilation aborted at t/timex.t line 26. > t/timex.....dubious > > > > This patch seems to solve the issues: > > diff -ruN Tk-PathEntry-2.17/t/dialog.t Tk-PathEntry-2.17.p1/t/dialog.t > --- Tk-PathEntry-2.17/t/dialog.t 2001-05-04 20:56:23.000000000 > +0200 > +++ Tk-PathEntry-2.17.p1/t/dialog.t 2003-11-12 17:25:47.462024000 > +0100 > @@ -43,7 +43,7 @@ > my $f2 = $top->getSaveFile(-title => "File to save", > -initialfile => "$ENV{HOME}/.cshrc", > -defaultextension => "ignored", > - -filetypes => ["ignored"], > + -filetypes => [["ignored", "*"]], > ); > yc($f2); > ok(1); > diff -ruN Tk-PathEntry-2.17/t/timex.t Tk-PathEntry-2.17.p1/t/timex.t > --- Tk-PathEntry-2.17/t/timex.t 2001-12-03 15:10:15.000000000 +0100 > +++ Tk-PathEntry-2.17.p1/t/timex.t 2003-11-13 08:35:39.758024000 > +0100 > @@ -11,6 +11,7 @@ > use Tk; > use Tk::PathEntry; > > +my $ok; > BEGIN { > if (!eval q{ > use Test; > @@ -21,11 +22,15 @@ > print "# tests only work with installed Test and Timex::Project > module\n"; > print "1..1\n"; > print "ok 1\n"; > - exit; > + $ok = 0; > + } else { > + $ok = 1; > } > } > > -BEGIN { plan tests => 2 } > +exit 0 unless($ok); > + > +plan tests => 2; > > my $timex_project_text = <<'EOF'; > #PJ1 -*- project -*- > > > But: When choosing file "startx" from my home directory in > t/dialog.t, then I get an error box saying: > File "/home/hwadm/startxignored" does not exist. > With other files, this does not happen, but I did not find > out the root cause. Bug or feature? ;-) >

Thanks for the report. The problem are some internal changes in the beta 804 release of Tk, which I guess you use. "use Tk" overrides exit() and seems to be noisy now in some circumstances. I changed the exit() call to CORE::exit(). The other problem is that you're getting the standard FBox fileselector in the t/dialog.t test, where the standard fileselector should be replaced by the one PathEntry.pm provides. This is also caused by an internal Tk change and is fixed now. Expect a new release tonight or tomorrow. Thanks & regards, Slaven -- __o Slaven Rezic _`\<,_ slaven <at> rezic <dot> de __(_)/ (_)____ Show quoted text

______________________________________________________________________________

Thu Nov 13 06:31:27 2003 SREZIC [...] cpan.org - Status changed from 'new' to 'resolved'