| Subject: | Darwin does not pass tests (OSX 10.5) |
This modules fails install on OSX 10.5 for two reasons. First is that in
the Darwin.pm subclass, "->{special}" is set explicitly to 0. This
defeats the check for regular filesystems, which looks for either the
absence of the key or the value being undef. This is also different from
the other subclasses (they don't explicitly set it to 0) so deleting
this line seems like the right thing.
The other one is trickier. There is a test of "options". But Darwin does
not set any options, so the test always fails (since options come back
as undef). I chose an approach of returning a static string (' '). It
might be more appropriate to remove the test, or make it optional since
this is kind of hacky.
Other than that...thanks for a nice clean module!
| Subject: | darwin.patch |
*** Wildcards.pm.orig 2009-02-25 20:33:39.000000000 -0800
--- Wildcards.pm 2009-02-25 20:34:13.000000000 -0800
*************** my %types = (
*** 69,74 ****
--- 69,75 ----
win32 => [ qw/jokers commas/ ],
);
$types{$_} = $types{win32} for qw/dos os2 MSWin32 cygwin/;
+ $types{$_} = $types{unix} for qw/darwin/;
my %escapes = (
jokers => '?*',