Bug #43506 for Template-Plugin-JSON: warning typo

Sun Feb 22 08:17:03 2009 frank.wiegand [...] gmail.com - Ticket created

Subject:

warning typo

This is against 0.04: diff --git a/lib/Template/Plugin/JSON.pm b/lib/Template/Plugin/JSON.pm index dbe4612..6d63e32 100644 --- a/lib/Template/Plugin/JSON.pm +++ b/lib/Template/Plugin/JSON.pm @@ -33,7 +33,7 @@ sub BUILDARGS { my ( $class, $c, $args ) = @_; unless ( ref $args ) { - warn "Single arguent form is deprecated, this module always uses JSON/JSON::XS now"; + warn "Single argument form is deprecated, this module always uses JSON/JSON::XS now"; $args = {}; } It's also annoying, that [% USE JSON %] issues this warning. Maybe it should only be thrown if there is really a single argument (that is not an empty list). Thanks, Frank

Mon Mar 02 14:23:44 2009 dekimsey [...] gmail.com - Correspondence added

Subject:	warning typo & inaccuracies.
From:	dekimsey [...] gmail.com

./agree The warning is rather inaccurate when no arguments are provided (as per example).

Mon Mar 02 14:23:45 2009 The RT System itself - Status changed from 'new' to 'open'

Mon Mar 02 19:25:20 2009 NUFFIN [...] cpan.org - Correspondence added

Cool, thanks. BTW, I see you're using git- you can just patch with http://github.com/nothingmuch/template-plugin-json/ if you like. If not I will apply the diff and release tomorrow (i'm a little swamped right now) after I fix the no args case as well. I should update the docs to point at github I guess... On Sun Feb 22 08:17:03 2009, frank.wiegand wrote: Show quoted text

> This is against 0.04: > > diff --git a/lib/Template/Plugin/JSON.pm b/lib/Template/Plugin/JSON.pm > index dbe4612..6d63e32 100644 > --- a/lib/Template/Plugin/JSON.pm > +++ b/lib/Template/Plugin/JSON.pm > @@ -33,7 +33,7 @@ sub BUILDARGS { > my ( $class, $c, $args ) = @_; > > unless ( ref $args ) { > - warn "Single arguent form is deprecated, this module > always uses JSON/JSON::XS now"; > + warn "Single argument form is deprecated, this module > always uses JSON/JSON::XS now"; > $args = {}; > } > > > It's also annoying, that [% USE JSON %] issues this warning. Maybe it > should only be thrown if there is really a single argument (that is not > an empty list). > > > Thanks, Frank

Tue Mar 03 18:08:56 2009 NUFFIN [...] cpan.org - Correspondence added

0.05 released

Tue Mar 03 18:08:57 2009 NUFFIN [...] cpan.org - Status changed from 'open' to 'resolved'