Bug #43404 for Unicode-Map8: 64-bit patch

Wed Feb 18 14:06:31 2009 g.grigelionis [...] gmail.com - Ticket created

Subject:	64-bit patch
Date:	Wed, 18 Feb 2009 20:05:55 +0100
To:	bug-Unicode-Map8 [...] rt.cpan.org
From:	Gintautas Grigelionis <g.grigelionis [...] gmail.com>

Please apply the following to make the 64-bit builds work --- map8.h +++ map8.h @@ -81,7 +81,7 @@ U16* map8_to_str16(Map8*, U8*, U16*, int, int*); U8* map8_to_str8 (Map8*, U16*, U8*, int, int*); -U8* map8_recode_8(Map8*, Map8*, U8*, U8*, int, int*); +U8* map8_recode8 (Map8*, Map8*, U8*, U8*, int, int*); int map8_empty_block(Map8*, U8); --- Map8.xs +++ Map8.xs @@ -348,7 +348,7 @@ Map8* m2 PREINIT: STRLEN len; - STRLEN rlen; + int rlen; char* res; INPUT: char* str = SvPV(ST(2), len);

Wed Jul 22 01:14:23 2009 MARKLE [...] cpan.org - Correspondence added

Message body is not shown because it is too large.

Wed Jul 22 01:14:23 2009 The RT System itself - Status changed from 'new' to 'open'

Wed Jul 22 01:17:31 2009 MARKLE [...] cpan.org - Correspondence added

In summary... Show quoted text

> map8x.c: In function ‘map8_recode8’: > map8x.c:322: warning: pointer targets in passing argument 1 of > ‘strlen’ > differ in signedness > map8x.c:315: warning: unused variable ‘uc’ > Map8.xs: In function ‘to8_cb’: > Map8.xs:84: warning: pointer targets in return differ in signedness > Map8.xs: In function ‘XS_Unicode__Map8__empty_block’: > Map8.xs:201: warning: comparison is always false due to limited range > of > data type > Map8.c: In function ‘XS_Unicode__Map8_to16’: > Map8.c:564: warning: pointer targets in initialization differ in > signedness > Map8.xs: In function ‘XS_Unicode__Map8_recode8’: > Map8.xs:359: warning: implicit declaration of function ‘map8_recode8’ > Map8.c: At top level: > /usr/lib64/perl5/5.8.8/x86_64-linux-thread- > multi/CORE/patchlevel.h:122: > warning: ‘local_patches’ defined but not used > rm -f blib/arch/auto/Unicode/Map8/Map8.so > gcc -shared -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions > -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic Map8.o > map8x.o -o blib/arch/auto/Unicode/Map8/Map8.so \ > \ > > chmod 755 blib/arch/auto/Unicode/Map8/Map8.so > Manifying blib/man1/umap.1 > Manifying blib/man3/Unicode::Map8.3pm > GAAS/Unicode-Map8-0.12.tar.gz > /usr/bin/make -j5 -j5 -- OK > Running make test > PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" > "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > t/callback.t .. ok > t/compat.t .... ok > t/map8.t ...... No subtests run > t/unistr.t .... ok > > Test Summary Report > ------------------- > t/map8.t (Wstat: 11 Tests: 0 Failed: 0) > Non-zero wait status: 11 > Parse errors: No plan found in TAP output > Files=4, Tests=6, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.09 cusr > 0.02 csys = 0.15 CPU) > Result: FAIL > Failed 1/4 test programs. 0/6 subtests failed. > make: *** [test_dynamic] Error 255 > GAAS/Unicode-Map8-0.12.tar.gz > /usr/bin/make test -- NOT OK > //hint// to see the cpan-testers results for installing this module, > try: > reports GAAS/Unicode-Map8-0.12.tar.gz

Show quoted text

> Failed during this command: > GAAS/Unicode-Map8-0.12.tar.gz : make_test FAILED but > failure ignored because 'force' in effect >

Wed Jul 22 07:33:19 2009 g.grigelionis [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #43404] 64-bit patch
Date:	Wed, 22 Jul 2009 13:32:56 +0200
To:	bug-Unicode-Map8 [...] rt.cpan.org
From:	Gintautas Grigelionis <g.grigelionis [...] gmail.com>

Map8.xs: In function ‘XS_Unicode__Map8_recode8’: Map8.xs:359: warning: implicit declaration of function ‘map8_recode8’ tells you there's a typo in map8.h Map8.c: In function ‘XS_Unicode__Map8_to16’: Map8.c:564: warning: pointer targets in initialization differ in signedness tells you STRLEN is not a correct type for rlen. If you use "prove -v -I blib/lib -I blib/auto t" you may see perl coredump. 2009/7/22 Mark Hedges via RT <bug-Unicode-Map8@rt.cpan.org> Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=43404 > > > In summary... >

> > map8x.c: In function ‘map8_recode8’: > > map8x.c:322: warning: pointer targets in passing argument 1 of > > ‘strlen’ > > differ in signedness > > map8x.c:315: warning: unused variable ‘uc’ > > Map8.xs: In function ‘to8_cb’: > > Map8.xs:84: warning: pointer targets in return differ in signedness > > Map8.xs: In function ‘XS_Unicode__Map8__empty_block’: > > Map8.xs:201: warning: comparison is always false due to limited range > > of > > data type > > Map8.c: In function ‘XS_Unicode__Map8_to16’: > > Map8.c:564: warning: pointer targets in initialization differ in > > signedness > > Map8.xs: In function ‘XS_Unicode__Map8_recode8’: > > Map8.xs:359: warning: implicit declaration of function ‘map8_recode8’ > > Map8.c: At top level: > > /usr/lib64/perl5/5.8.8/x86_64-linux-thread- > > multi/CORE/patchlevel.h:122: > > warning: ‘local_patches’ defined but not used > > rm -f blib/arch/auto/Unicode/Map8/Map8.so > > gcc -shared -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions > > -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic Map8.o > > map8x.o -o blib/arch/auto/Unicode/Map8/Map8.so \ > > \ > > > > chmod 755 blib/arch/auto/Unicode/Map8/Map8.so > > Manifying blib/man1/umap.1 > > Manifying blib/man3/Unicode::Map8.3pm > > GAAS/Unicode-Map8-0.12.tar.gz > > /usr/bin/make -j5 -j5 -- OK > > Running make test > > PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" > > "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t > > t/callback.t .. ok > > t/compat.t .... ok > > t/map8.t ...... No subtests run > > t/unistr.t .... ok > > > > Test Summary Report > > ------------------- > > t/map8.t (Wstat: 11 Tests: 0 Failed: 0) > > Non-zero wait status: 11 > > Parse errors: No plan found in TAP output > > Files=4, Tests=6, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.09 cusr > > 0.02 csys = 0.15 CPU) > > Result: FAIL > > Failed 1/4 test programs. 0/6 subtests failed. > > make: *** [test_dynamic] Error 255 > > GAAS/Unicode-Map8-0.12.tar.gz > > /usr/bin/make test -- NOT OK > > //hint// to see the cpan-testers results for installing this module, > > try: > > reports GAAS/Unicode-Map8-0.12.tar.gz

>

> > Failed during this command: > > GAAS/Unicode-Map8-0.12.tar.gz : make_test FAILED but > > failure ignored because 'force' in effect > >

> > > >