Bug #43353 for Syntax-Highlight-Engine-Simple: test fails with Perl::Critic 1.096

Tue Feb 17 06:30:17 2009 bremner-dated-1236079790.78837d [...] pivot.cs.unb.ca - Ticket created

Subject:	test fails with Perl::Critic 1.096
Date:	Tue, 17 Feb 2009 07:29:48 -0400
To:	bug-Syntax-Highlight-Engine-Simple [...] rt.cpan.org
From:	David Bremner <bremner [...] unb.ca>

With Perl::Critic 1.096 Test::Perl::Critic 1.01 perl 5.10.0 All from Debian packages, I get the following failure in version 0.08 of Syntax::Highlight::Engine::Simple % perl t/perlcritic.t 1..1 not ok 1 - Test::Perl::Critic for "lib/Syntax/Highlight/Engine/Simple.pm" # Failed test 'Test::Perl::Critic for "lib/Syntax/Highlight/Engine/Simple.pm"' # at /usr/share/perl5/Test/Perl/Critic.pm line 99. # # Perl::Critic found these violations in "lib/Syntax/Highlight/Engine/Simple.pm": # "return" statement followed by "sort" at line 358, column 5. Behavior is undefined if called in scalar context. (Severity: 5) # Looks like you failed 1 test of 1.

Fri May 22 19:50:02 2009 frequency [...] cpan.org - Correspondence added

From:

frequency [...] cpan.org

This is fixed in Debian with the following patch: --- a/lib/Syntax/Highlight/Engine/Simple.pm +++ b/lib/Syntax/Highlight/Engine/Simple.pm @@ -354,13 +354,15 @@ [$$map_ref[$i]->[1]] ); } - - return + + @out_array = sort { $$a[0] <=> $$b[0] #or #(defined $$a[1]) <=> (defined $$b[1]) } @out_array; + + return @out_array; } Thanks, Jonathan On Tue Feb 17 06:30:17 2009, bremner-dated-1236079790.78837d@pivot.cs.unb.ca wrote: Show quoted text

> With Perl::Critic 1.096 > Test::Perl::Critic 1.01 > perl 5.10.0 > > All from Debian packages, > > I get the following failure in version 0.08 of > Syntax::Highlight::Engine::Simple > > % perl t/perlcritic.t > 1..1 > not ok 1 - Test::Perl::Critic for > "lib/Syntax/Highlight/Engine/Simple.pm" > # Failed test 'Test::Perl::Critic for > "lib/Syntax/Highlight/Engine/Simple.pm"' > # at /usr/share/perl5/Test/Perl/Critic.pm line 99. > # > # Perl::Critic found these violations in > "lib/Syntax/Highlight/Engine/Simple.pm": > # "return" statement followed by "sort" at line 358, column 5. > Behavior is undefined if called in scalar context. (Severity: 5) > # Looks like you failed 1 test of 1. >

Fri May 22 19:50:04 2009 The RT System itself - Status changed from 'new' to 'open'

Fri Aug 19 10:07:56 2011 fschlich [...] cis.fu-berlin.de - Correspondence added

From:

fschlich [...] cis.fu-berlin.de

I believe this bug was fixed in Syntax-Highlight-Engine-Simple-0.09, the patch is no longer shipped in the Debian package. (I'd close the bug but I can't) Florian